WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
61476
Generate regexp code lazily
https://bugs.webkit.org/show_bug.cgi?id=61476
Summary
Generate regexp code lazily
Oliver Hunt
Reported
2011-05-25 15:31:43 PDT
Generate regexp code lazily
Attachments
Patch
(12.81 KB, patch)
2011-05-25 15:33 PDT
,
Oliver Hunt
ggaren
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Oliver Hunt
Comment 1
2011-05-25 15:33:20 PDT
Created
attachment 94872
[details]
Patch
Geoffrey Garen
Comment 2
2011-05-25 15:45:30 PDT
Comment on
attachment 94872
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=94872&action=review
r=me
> Source/JavaScriptCore/runtime/RegExp.cpp:113 > +void RegExp::recompile(JSGlobalData& globalData) > +{ > + m_representation = adoptPtr(new RegExpRepresentation); > + m_state = compile(&globalData); > +} > + > RegExp::RegExpState RegExp::compile(JSGlobalData* globalData)
I think these two functions should merge into a function called "compile", and "recompileIfNecessary" should be "compileIfNecessary", since it gets called for initial compilation, and not just recompilation.
Oliver Hunt
Comment 3
2011-05-25 15:50:16 PDT
Committed
r87327
: <
http://trac.webkit.org/changeset/87327
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug