Bug 61438 - [Qt] fast/css/disabled-author-styles.html failed
Summary: [Qt] fast/css/disabled-author-styles.html failed
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: qi
Keywords: Qt
Depends on:
Reported: 2011-05-25 08:08 PDT by qi
Modified: 2011-05-25 12:20 PDT (History)
4 users (show)

See Also:

patch (15.58 KB, patch)
2011-05-25 08:13 PDT, qi
no flags Details | Formatted Diff | Diff
patch2 (15.49 KB, patch)
2011-05-25 08:20 PDT, qi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description qi 2011-05-25 08:08:02 PDT
LayoutTestControllerQt doesn't implement setAuthorAndUserStylesEnabled.
Comment 1 qi 2011-05-25 08:13:32 PDT
Created attachment 94784 [details]
Comment 2 WebKit Review Bot 2011-05-25 08:17:02 PDT
Attachment 94784 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1

Tools/DumpRenderTree/qt/LayoutTestControllerQt.h:172:  The parameter name "enable" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 9 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 qi 2011-05-25 08:20:16 PDT
Created attachment 94785 [details]

fix style issue.
Comment 4 Andreas Kling 2011-05-25 10:40:54 PDT
Comment on attachment 94785 [details]

Comment 5 WebKit Commit Bot 2011-05-25 12:20:41 PDT
Comment on attachment 94785 [details]

Clearing flags on attachment: 94785

Committed r87311: <http://trac.webkit.org/changeset/87311>
Comment 6 WebKit Commit Bot 2011-05-25 12:20:46 PDT
All reviewed patches have been landed.  Closing bug.