Bug 61424 - [BlackBerry][EFL][GTK][WIN][WX] Remove ScriptControllerXXX.cpp to reduce duplication
Summary: [BlackBerry][EFL][GTK][WIN][WX] Remove ScriptControllerXXX.cpp to reduce dupl...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-25 00:33 PDT by Ryuan Choi
Modified: 2012-08-10 19:03 PDT (History)
8 users (show)

See Also:

Attachments
Patch (18.28 KB, patch)
2012-08-06 15:41 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Patch (16.74 KB, patch)
2012-08-08 00:53 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2011-05-25 00:33:21 PDT 
ScriptControllerBrew, ScriptControllerEfl, ScriptControllerGtk, ScriptControllerHaiku, ScriptControllerWin and ScriptControllerWx are almost same.
I believe that mering them will reduce duplication.
Comment 1 Patrick R. Gansterer 2011-06-01 08:15:52 PDT 
This bug is independet from CMake (bug 61350), so reopening it.
This is more a general cleanup to reduce file copies!
Comment 2 Ryuan Choi 2012-08-06 15:41:00 PDT 
Created attachment 156775 [details]
Patch
Comment 3 Gyuyoung Kim 2012-08-07 02:00:40 PDT 
Comment on attachment 156775 [details]
Patch

I think this is good refactoring. Thanks.
Comment 4 Ryosuke Niwa 2012-08-08 00:15:09 PDT 
Comment on attachment 156775 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156775&action=review

> Source/WebCore/bindings/js/ScriptControllerDefault.cpp:40
> +PassRefPtr<JSC::Bindings::Instance> ScriptController::createScriptInstanceForWidget(Widget* widget)

I would prefer moving it to ScriptController and if-def it for mac & qt.
Comment 5 Ryuan Choi 2012-08-08 00:53:18 PDT 
Created attachment 157143 [details]
Patch
Comment 6 Ryuan Choi 2012-08-08 00:54:19 PDT 
(In reply to comment #4)
> (From update of attachment 156775 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=156775&action=review
> 
> > Source/WebCore/bindings/js/ScriptControllerDefault.cpp:40
> > +PassRefPtr<JSC::Bindings::Instance> ScriptController::createScriptInstanceForWidget(Widget* widget)
> 
> I would prefer moving it to ScriptController and if-def it for mac & qt.

Ok, I moved like you mentioned.
Comment 7 Rob Buis 2012-08-10 10:18:14 PDT 
Comment on attachment 157143 [details]
Patch

LGTM.
Comment 8 WebKit Review Bot 2012-08-10 19:03:06 PDT 
Comment on attachment 157143 [details]
Patch

Clearing flags on attachment: 157143

Committed r125346: <http://trac.webkit.org/changeset/125346>
Comment 9 WebKit Review Bot 2012-08-10 19:03:12 PDT 
All reviewed patches have been landed.  Closing bug.