Bug 61407 – QuickLooks quirk is expensive to calculate

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Stephanie Lewis]

Remove quicklooks quirk from preferences since we don't need to set on every page.  We only care about it when the user is reloading a page.
Move the check for the quirk to after several other reload checks.
Don't use the quirk for Safari.

part of <rdar://problem/8675177>

[Stephanie Lewis]

Created attachment 94726 [details]
patch

[Early Warning System Bot]

Comment on attachment 94726 [details]
patch

Attachment 94726 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/8726917

[Stephanie Lewis]

Created attachment 94728 [details]
patch - properly ifdef'd this time

[WebKit Review Bot]

Attachment 94728 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/loader/FrameLoader.cpp:2416:  More than one command on the same line in if  [whitespace/parens] [4]
Source/WebCore/loader/FrameLoader.cpp:2419:  More than one command on the same line in if  [whitespace/parens] [4]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 94728 [details]
patch - properly ifdef'd this time

Attachment 94728 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/8734297

[Stephanie Lewis]

Created attachment 94729 [details]
patch

[WebKit Review Bot]

Comment on attachment 94726 [details]
patch

Attachment 94726 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8734295

[WebKit Review Bot]

Comment on attachment 94728 [details]
patch - properly ifdef'd this time

Attachment 94728 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8734299

[WebKit Review Bot]

Comment on attachment 94729 [details]
patch

Attachment 94729 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8726927

New failing tests:
http/tests/cache/post-redirect-get.php

[WebKit Review Bot]

Created attachment 94732 [details]
Archive of layout-test-results from ec2-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01  Port: Chromium  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Stephanie Lewis]

Created attachment 94748 [details]
patch

[Brady Eidson]

Comment on attachment 94748 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=94748&action=review

r+ with the following changes:

> Source/WebCore/loader/FrameLoader.cpp:2416
> +    if (request.cachePolicy() == ReloadIgnoringCacheData && ResourceRequest::useQuickLookResourceCachingQuirks() && !equalIgnoringCase(request.httpMethod(), "post"))

You can put the !equalIgnoringCase(request.httpMethod(), "post") before the useQuickLookResourceCachingQuirks() for an even more "less likely to calculate the quicklooks quirks" setup.

> Source/WebCore/platform/network/mac/ResourceRequestMac.mm:182
> +    const char* bundleID = [[[NSBundle mainBundle] bundleIdentifier] UTF8String];
> +    if (bundleID && !strcasecmp(bundleID, "com.apple.Safari"))
> +        return false;

You should use applicationIsSafari() in RuntimeApplicationChecks

[Stephanie Lewis]

committed http://trac.webkit.org/projects/webkit/changeset/87329

[Stephanie Lewis]

<rdar://problem/9504417>