Bug 61406 - Move HTMLSelectElement::setMultiple logic to attribute handling/parsing code
Summary: Move HTMLSelectElement::setMultiple logic to attribute handling/parsing code
Status: RESOLVED DUPLICATE of bug 252969
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-24 17:45 PDT by Emil A Eklund
Modified: 2023-12-19 08:04 PST (History)
7 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2011-05-24 17:45:36 PDT 
From comment on bug 60986:
<darin> It doesn’t make sense that setting multiple with the binding directly does something different than setting the multiple attribute; all the code to handle the change from single to multiple needs to be in the attribute handling/parsing code and none should be in the setMultiple function. I think all the code in setMultiple is probably wrong. We should test the behavior in other browsers to be sure but I think that is the way to go and this refinement of the code is not sufficient.
Comment 1 Ahmad Saleem 2022-09-16 23:27:45 PDT 
rniwa - we still have this:

https://github.com/WebKit/WebKit/blob/5a8883c75f0a425515a601a4eb8de66e88ada97d/Source/WebCore/html/HTMLSelectElement.cpp#L426

Is this something still needed to be changed or this can be marked as "RESOLVED LATER" for future?
Comment 2 Anne van Kesteren 2023-12-19 08:04:41 PST 

*** This bug has been marked as a duplicate of bug 252969 ***