WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
61399
Split HeapRootVisitor into its own class
https://bugs.webkit.org/show_bug.cgi?id=61399
Summary
Split HeapRootVisitor into its own class
Geoffrey Garen
Reported
2011-05-24 15:05:38 PDT
Split HeapRootVisitor into its own class
Attachments
Patch
(27.73 KB, patch)
2011-05-24 15:08 PDT
,
Geoffrey Garen
oliver
: review+
commit-queue
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Geoffrey Garen
Comment 1
2011-05-24 15:08:29 PDT
Created
attachment 94699
[details]
Patch
WebKit Review Bot
Comment 2
2011-05-24 15:12:15 PDT
Attachment 94699
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/heap/HandleHeap.cpp:30: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptCore/heap/HeapRootVisitor.h:37: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/JavaScriptCore/runtime/ArgList.cpp:28: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 3 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 3
2011-05-24 16:46:40 PDT
Committed
r87230
: <
http://trac.webkit.org/changeset/87230
>
WebKit Commit Bot
Comment 4
2011-05-24 17:03:08 PDT
Comment on
attachment 94699
[details]
Patch
Attachment 94699
[details]
did not pass mac-ews (mac): Output:
http://queues.webkit.org/results/8726860
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug