Bug 61395 - Add FIXME comments about removing FrameLoader::isProcessingUserGesture
Summary: Add FIXME comments about removing FrameLoader::isProcessingUserGesture
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-24 14:20 PDT by Adam Barth
Modified: 2011-05-24 20:39 PDT (History)
4 users (show)

See Also:

Attachments
Patch (6.81 KB, patch)
2011-05-24 14:22 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-05-24 14:20:26 PDT 
Add FIXME comments about removing FrameLoader::isProcessingUserGesture
Comment 1 Adam Barth 2011-05-24 14:22:28 PDT 
Created attachment 94687 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-05-24 19:11:58 PDT 
Comment on attachment 94687 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=94687&action=review

OK.

> Source/WebCore/html/HTMLMediaElement.cpp:2410
> +    return frame->loader()->isProcessingUserGesture();

A frame always has a frameloader?
Comment 3 Adam Barth 2011-05-24 19:20:21 PDT 
(In reply to comment #2)
> (From update of attachment 94687 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=94687&action=review
> 
> OK.
> 
> > Source/WebCore/html/HTMLMediaElement.cpp:2410
> > +    return frame->loader()->isProcessingUserGesture();
> 
> A frame always has a frameloader?

Yes, definitely.
Comment 4 WebKit Commit Bot 2011-05-24 20:39:41 PDT 
Comment on attachment 94687 [details]
Patch

Clearing flags on attachment: 94687

Committed r87260: <http://trac.webkit.org/changeset/87260>
Comment 5 WebKit Commit Bot 2011-05-24 20:39:46 PDT 
All reviewed patches have been landed.  Closing bug.