WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
61395
Add FIXME comments about removing FrameLoader::isProcessingUserGesture
https://bugs.webkit.org/show_bug.cgi?id=61395
Summary
Add FIXME comments about removing FrameLoader::isProcessingUserGesture
Adam Barth
Reported
2011-05-24 14:20:26 PDT
Add FIXME comments about removing FrameLoader::isProcessingUserGesture
Attachments
Patch
(6.81 KB, patch)
2011-05-24 14:22 PDT
,
Adam Barth
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adam Barth
Comment 1
2011-05-24 14:22:28 PDT
Created
attachment 94687
[details]
Patch
Eric Seidel (no email)
Comment 2
2011-05-24 19:11:58 PDT
Comment on
attachment 94687
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=94687&action=review
OK.
> Source/WebCore/html/HTMLMediaElement.cpp:2410 > + return frame->loader()->isProcessingUserGesture();
A frame always has a frameloader?
Adam Barth
Comment 3
2011-05-24 19:20:21 PDT
(In reply to
comment #2
)
> (From update of
attachment 94687
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=94687&action=review
> > OK. > > > Source/WebCore/html/HTMLMediaElement.cpp:2410 > > + return frame->loader()->isProcessingUserGesture(); > > A frame always has a frameloader?
Yes, definitely.
WebKit Commit Bot
Comment 4
2011-05-24 20:39:41 PDT
Comment on
attachment 94687
[details]
Patch Clearing flags on attachment: 94687 Committed
r87260
: <
http://trac.webkit.org/changeset/87260
>
WebKit Commit Bot
Comment 5
2011-05-24 20:39:46 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug