Bug 61390 - Add IntPoint versions of IntRect::move and IntPoint::move
Summary: Add IntPoint versions of IntRect::move and IntPoint::move
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Levi Weintraub
URL:
Keywords:
Depends on:
Blocks: 60806
  Show dependency tree / graph
 
Reported: 2011-05-24 13:32 PDT by Emil A Eklund
Modified: 2011-05-25 10:06 PDT (History)
4 users (show)

See Also:

Attachments
Patch (24.28 KB, patch)
2011-05-24 14:30 PDT, Levi Weintraub 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2011-05-24 13:32:18 PDT 
From bug 60806
> It's a bit strange, but perhaps we should consider a flavor of IntRect::move that takes a point?
Comment 1 Levi Weintraub 2011-05-24 13:35:59 PDT 
Thanks! I was in the middle of filing this. I'm partly through implementing it and changing a bunch of existing call sites :)
Comment 2 Levi Weintraub 2011-05-24 14:30:38 PDT 
Created attachment 94688 [details]
Patch
Comment 3 Eric Seidel (no email) 2011-05-24 19:10:00 PDT 
Comment on attachment 94688 [details]
Patch

Seems OK to me, but others may have concerns about the IntSize vs. IntPoint purity.
Comment 4 Levi Weintraub 2011-05-25 10:06:36 PDT 
Comment on attachment 94688 [details]
Patch

Clearing flags on attachment: 94688

Committed r87303: <http://trac.webkit.org/changeset/87303>
Comment 5 Levi Weintraub 2011-05-25 10:06:41 PDT 
All reviewed patches have been landed.  Closing bug.