Bug 61364 - Web Inspector: inspected page crashes when call stack is empty after live edit.
Summary: Web Inspector: inspected page crashes when call stack is empty after live edit.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-24 08:29 PDT by Pavel Podivilov
Modified: 2011-05-25 02:03 PDT (History)
10 users (show)

See Also:

Attachments
Patch. (1.73 KB, patch)
2011-05-24 08:29 PDT, Pavel Podivilov 		yurys: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2011-05-24 08:29:12 PDT 
Web Inspector: inspected page crashes when call stack is empty after live edit.
Comment 1 Pavel Podivilov 2011-05-24 08:29:46 PDT 
Created attachment 94614 [details]
Patch.
Comment 2 Yury Semikhatsky 2011-05-24 09:08:06 PDT 
Comment on attachment 94614 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=94614&action=review

> Source/WebCore/bindings/v8/ScriptDebugServer.cpp:252
> +    if (currentCallFrameV8->IsObject())

Prefer early return.
Comment 3 Yury Semikhatsky 2011-05-24 09:08:29 PDT 
Can we have a test for this case?
Comment 4 Pavel Podivilov 2011-05-25 02:03:36 PDT 
Committed r87280: <http://trac.webkit.org/changeset/87280>