Bug 61342 – Regression(r87118): chromium/mac: scroll layout tests failures

• Status: RESOLVED
• Resolution: WONTFIX
• Component: Layout and Rendering

[Fumitoshi Ukai]

Since r87118, chromium/mac started failing layout tests of scroll.

fast/repaint/fixed-move-after-keyboard-scroll.html = IMAGE+TEXT
fast/dom/vertical-scrollbar-in-rtl.html = TEXT
fast/events/node-event-anchor-lock.html = TEXT
fast/events/scroll-after-click-on-tab-index.html = TEXT
fast/events/scrollbar-double-click.html = TEXT

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20chromium.org&tests=fast%2Frepaint%2Ffixed-move-after-keyboard-scroll.html%2Cfast%2Fdom%2Fvertical-scrollbar-in-rtl.html%2Cfast%2Fevents%2Fnode-event-anchor-lock.html%2Cfast%2Fevents%2Fscroll-after-click-on-tab-index.html%2Cfast%2Fevents%2Fscrollbar-double-click.html

[Sailesh Agrawal]

Sorry for breaking the tests. Adding relevant links:
http://trac.webkit.org/changeset/87126
http://trac.webkit.org/changeset/87130

[Sailesh Agrawal]

Hi Ukai, I can't reproduce the test failure. All 5 tests pass for me.

[Sailesh Agrawal]

CCing jamesr and thakis in case there's something I should be doing that I'm not.

[James Robinson]

(In reply to comment #3)
> CCing jamesr and thakis in case there's something I should be doing that I'm not.

Well, what are you doing?

[Sailesh Agrawal]

I ran:
   Tools/Scripts/new-run-webkit-tests --debug --chromium
on tip of tree with and without my change and it passes. Not sure how to reproduce the failure from the dashboard link.

[Sailesh Agrawal]

Created attachment 94868 [details]
Patch

[Sailesh Agrawal]

I've updated a new patch that re-adds the reverted code. The patch contains the following additional changes:
- remove text exceptions
- disable smooth scrolling in ScrollAnimatorChroimiumMac::scroll()

[Sailesh Agrawal]

Created attachment 95028 [details]
Patch

[Sailesh Agrawal]

Scroll tests no loger fail on the try bots with this patch:
http://build.chromium.org/p/tryserver.chromium/builders/mac_layout_rel/builds/194
For comparison here's the output from the try bot with an empty change list:
http://build.chromium.org/p/tryserver.chromium/builders/mac_layout_rel/builds/191

[Sailesh Agrawal]

Here's the result for my patch on the mac_layout bot:
http://build.chromium.org/p/tryserver.chromium/builders/mac_layout/builds/633

[Tony Chang]

Comment on attachment 95028 [details]
Patch

I suggest you reopen bug 59753 and post this patch there with the change description from your original patch.  I would include what changes you made since the first time this patch landed (to make the review easier).  I would also ask jamesr to review the change since he gave the original r+.

[Stephen Chenney]

LayoutTest failures for Chromium are being marked WontFix. The Bug is still accessible and referenced from TestExpectations.