Bug 61342 - Regression(r87118): chromium/mac: scroll layout tests failures
Summary: Regression(r87118): chromium/mac: scroll layout tests failures
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2011-05-23 21:50 PDT by Fumitoshi Ukai
Modified: 2013-04-09 16:10 PDT (History)
3 users (show)

See Also:

Patch (63.27 KB, patch)
2011-05-25 15:17 PDT, Sailesh Agrawal
no flags Details | Formatted Diff | Diff
Patch (64.11 KB, patch)
2011-05-26 13:32 PDT, Sailesh Agrawal
tony: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fumitoshi Ukai 2011-05-23 21:50:00 PDT
Since r87118, chromium/mac started failing layout tests of scroll.

fast/repaint/fixed-move-after-keyboard-scroll.html = IMAGE+TEXT
fast/dom/vertical-scrollbar-in-rtl.html = TEXT
fast/events/node-event-anchor-lock.html = TEXT
fast/events/scroll-after-click-on-tab-index.html = TEXT
fast/events/scrollbar-double-click.html = TEXT

Comment 1 Sailesh Agrawal 2011-05-24 08:33:45 PDT
Sorry for breaking the tests. Adding relevant links:
Comment 2 Sailesh Agrawal 2011-05-24 11:08:01 PDT
Hi Ukai, I can't reproduce the test failure. All 5 tests pass for me.
Comment 3 Sailesh Agrawal 2011-05-24 16:00:20 PDT
CCing jamesr and thakis in case there's something I should be doing that I'm not.
Comment 4 James Robinson 2011-05-24 16:03:34 PDT
(In reply to comment #3)
> CCing jamesr and thakis in case there's something I should be doing that I'm not.

Well, what are you doing?
Comment 5 Sailesh Agrawal 2011-05-24 16:04:58 PDT
I ran:
   Tools/Scripts/new-run-webkit-tests --debug --chromium
on tip of tree with and without my change and it passes. Not sure how to reproduce the failure from the dashboard link.
Comment 6 Sailesh Agrawal 2011-05-25 15:17:28 PDT
Created attachment 94868 [details]
Comment 7 Sailesh Agrawal 2011-05-25 15:18:40 PDT
I've updated a new patch that re-adds the reverted code. The patch contains the following additional changes:
- remove text exceptions
- disable smooth scrolling in ScrollAnimatorChroimiumMac::scroll()
Comment 8 Sailesh Agrawal 2011-05-26 13:32:09 PDT
Created attachment 95028 [details]
Comment 9 Sailesh Agrawal 2011-05-26 13:34:29 PDT
Scroll tests no loger fail on the try bots with this patch:
For comparison here's the output from the try bot with an empty change list:
Comment 10 Sailesh Agrawal 2011-05-26 13:41:51 PDT
Here's the result for my patch on the mac_layout bot:
Comment 11 Tony Chang 2011-05-26 13:51:14 PDT
Comment on attachment 95028 [details]

I suggest you reopen bug 59753 and post this patch there with the change description from your original patch.  I would include what changes you made since the first time this patch landed (to make the review easier).  I would also ask jamesr to review the change since he gave the original r+.
Comment 12 Stephen Chenney 2013-04-09 16:10:55 PDT
LayoutTest failures for Chromium are being marked WontFix. The Bug is still accessible and referenced from TestExpectations.