WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
61314
[Qt] QtWebKit crashes when dragging not loaded images
https://bugs.webkit.org/show_bug.cgi?id=61314
Summary
[Qt] QtWebKit crashes when dragging not loaded images
Igor Trindade Oliveira
Reported
2011-05-23 15:21:04 PDT
QtWebKit crashes when dragging not loaded images.
Attachments
Test Case
(184 bytes, text/html)
2011-05-23 15:22 PDT
,
Igor Trindade Oliveira
no flags
Details
Patch
(1.75 KB, patch)
2011-05-23 15:27 PDT
,
Igor Trindade Oliveira
no flags
Details
Formatted Diff
Diff
Patch
(1.75 KB, patch)
2011-05-23 15:43 PDT
,
Igor Trindade Oliveira
kling
: review-
Details
Formatted Diff
Diff
Patch
(4.44 KB, patch)
2011-05-24 15:19 PDT
,
Igor Trindade Oliveira
no flags
Details
Formatted Diff
Diff
Patch
(4.43 KB, patch)
2011-05-25 07:05 PDT
,
Igor Trindade Oliveira
no flags
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Igor Trindade Oliveira
Comment 1
2011-05-23 15:22:17 PDT
Created
attachment 94500
[details]
Test Case To reproduce the bug try to drag the image when the page is loading.
Igor Trindade Oliveira
Comment 2
2011-05-23 15:27:27 PDT
Created
attachment 94502
[details]
Patch Proposed patch
WebKit Review Bot
Comment 3
2011-05-23 15:32:23 PDT
Attachment 94502
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/qt/DragImageQt.cpp:66: Declaration has space between type name and * in QPixmap *dragImage [whitespace/declaration] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Igor Trindade Oliveira
Comment 4
2011-05-23 15:43:50 PDT
Created
attachment 94507
[details]
Patch Proposed patch.
Alexis Menard (darktears)
Comment 5
2011-05-23 16:10:51 PDT
Comment on
attachment 94507
[details]
Patch Looks good but can you do a layout test? I know drag and drop are tricky but is there any existing drag and drop tests you could reuse?
Andreas Kling
Comment 6
2011-05-24 04:30:09 PDT
Comment on
attachment 94507
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=94507&action=review
Good catch! Needs a test though.
> Source/WebCore/platform/qt/DragImageQt.cpp:70 > - if (!image) > - return 0; > + QPixmap* dragImage = 0; > + if (image && image->nativeImageForCurrentFrame()) > + dragImage = new QPixmap(*image->nativeImageForCurrentFrame()); > > - return new QPixmap(*image->nativeImageForCurrentFrame()); > + return dragImage;
This would read better as: if (!image || !image->nativeImageForCurrentFrame()) return 0; return new QPixmap(*image->nativeImageForCurrentFrame());
Igor Trindade Oliveira
Comment 7
2011-05-24 15:19:34 PDT
Created
attachment 94702
[details]
Patch Proposed patch. Add test.
Alexis Menard (darktears)
Comment 8
2011-05-25 07:01:10 PDT
Comment on
attachment 94702
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=94702&action=review
> LayoutTests/ChangeLog:8 > + Checks if WebKit crashes when dragging a not loaded image.
dragging an image not yet loaded. better no?
Igor Trindade Oliveira
Comment 9
2011-05-25 07:05:40 PDT
Created
attachment 94778
[details]
Patch Proposed patch.
WebKit Commit Bot
Comment 10
2011-05-25 09:34:09 PDT
Comment on
attachment 94778
[details]
Patch Clearing flags on attachment: 94778 Committed
r87298
: <
http://trac.webkit.org/changeset/87298
>
WebKit Commit Bot
Comment 11
2011-05-25 09:34:14 PDT
All reviewed patches have been landed. Closing bug.
Simon Fraser (smfr)
Comment 12
2011-05-25 20:33:22 PDT
This test is crashing on Mac too. Seems like other platforms need a similar fix.
Simon Fraser (smfr)
Comment 13
2011-05-25 20:34:20 PDT
I filed
bug 61499
.
Antonio Gomes
Comment 14
2011-05-25 20:57:27 PDT
It was failing on Qt and no bot email/bug_comment was added to this bug, as it usually happen. Failing on Mac too (according to Simon and nothing yet from the emailer bot). Maybe there is a problem with them?
Philippe Normand
Comment 15
2011-05-26 02:30:15 PDT
Filed
bug 61513
for GTK
Igor Trindade Oliveira
Comment 16
2011-05-26 03:07:21 PDT
After
http://trac.webkit.org/changeset/87366
, mac is not failing anymore.
Ademar Reis
Comment 17
2011-05-26 08:56:47 PDT
Revision
r87298
cherry-picked into qtwebkit-2.2 with commit 8cfca23 <
http://gitorious.org/webkit/qtwebkit/commit/8cfca23
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug