Bug 61313 – [Qt] Add html5 hybrid example application to webkit trunk

• Status: RESOLVED
• Resolution: WONTFIX
• Component: WebKit Qt

[Keith Kyzivat]

It was suggested that a hybrid Qt + WebKit example application be added to webkit trunk, so that this support can be tested.

Right now there is no such example code - mixing native Qt application and QGraphicsWebView, and using the Qt Javascript bindings.
The idea is to have code in Webkit trunk that is similar to what is used in Qt Creator as the "Html5 Hybrid App Template", so that we can better support this in WebKit trunk.

[Kenneth Rohde Christiansen]

Sounds like a good idea.

[Keith Kyzivat]

Created attachment 94501 [details]
Patch

[WebKit Review Bot]

Attachment 94501 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/qt/ChangeLog', u'Source/WebK..." exit_code: 1

Source/WebKit/qt/examples/html5app/html5applicationviewer/touchnavigation/webtouchevent.cpp:9:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Source/WebKit/qt/examples/html5app/html5applicationviewer/touchnavigation/webtouchphysicsinterface.cpp:9:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Source/WebKit/qt/examples/html5app/html5applicationviewer/touchnavigation/webtouchnavigation.cpp:9:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Source/WebKit/qt/examples/html5app/html5applicationviewer/touchnavigation/webtouchscroller.cpp:9:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Source/WebKit/qt/examples/html5app/html5applicationviewer/html5applicationviewer.cpp:9:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Source/WebKit/qt/examples/html5app/html5applicationviewer/touchnavigation/webnavigation.cpp:9:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Source/WebKit/qt/examples/html5app/html5applicationviewer/touchnavigation/navigationcontroller.cpp:9:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Source/WebKit/qt/examples/html5app/html5applicationviewer/touchnavigation/webtouchphysics.cpp:9:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 8 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Keith Kyzivat]

WK style issues are known -- this is example code and should not include 'config.h'.

[Kenneth Rohde Christiansen]

(In reply to comment #4)
> WK style issues are known -- this is example code and should not include 'config.h'.

Well, there are places where you use WebKit style and others where you use Qt style. Choose one or the other. You can exclude the files from the style checker

[Benjamin Poulain]

Comment on attachment 94501 [details]
Patch

r-:
Examples should use Qt style, not WebKit style.
This example does not follow many of the documentation recommandation, please talk with the doc team.
All those #ifdef are unheard of for documentation. Especially things like this: #if 1 // DELETE_LINE

[Benjamin Poulain]

The documentation team had a look at the code and agree this is not good enough.

Examples are supposed to demonstrate a few key concepts and spread good coding practice.

I suggest to either:
-slim down the patch to a better example
-grow the code to real application and make it a demo

[Keith Kyzivat]

(In reply to comment #7)
> I suggest to either:
> -slim down the patch to a better example
> -grow the code to real application and make it a demo

My goal with this is to have this be very close to the template that is used in Qt Creator.  Qt Creator is currently has this with minor changes in their master branch.  I have been pushing merge requests to keep both this submission and the qt creator template in sync as best possible.  Obviously these may diverge to some degree, but the goal is to keep them similar.

With a Qt Creator template in mind, this cannot be a real demo application -- that would be too heavyweight and large for a template.  An example fits the bill though.

How do I go about getting in contact with the Qt documentation team?

[Benjamin Poulain]

(In reply to comment #8)
> My goal with this is to have this be very close to the template that is used in Qt Creator.  Qt Creator is currently has this with minor changes in their master branch.  I have been pushing merge requests to keep both this submission and the qt creator template in sync as best possible.  Obviously these may diverge to some degree, but the goal is to keep them similar.

Ok, what problem are you solving by putting such things in trunk then?


> How do I go about getting in contact with the Qt documentation team?

Contact Kevin Wright

[Laszlo Gombos]

I do not think there is a plan to pursue this further; changing the status to WONTFIX.