Bug 61250 - Use double quotes for filename arguments
Summary: Use double quotes for filename arguments
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks: 55811
  Show dependency tree / graph
 
Reported: 2011-05-22 09:27 PDT by Patrick R. Gansterer
Modified: 2011-05-22 11:08 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.19 KB, patch)
2011-05-22 09:31 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2011-05-22 09:27:52 PDT 
Use double quotes for filename arguments
Comment 1 Patrick R. Gansterer 2011-05-22 09:31:21 PDT 
Created attachment 94346 [details]
Patch
Comment 2 Adam Barth 2011-05-22 09:34:49 PDT 
Comment on attachment 94346 [details]
Patch

Test?
Comment 3 Patrick R. Gansterer 2011-05-22 09:38:57 PDT 
(In reply to comment #2)
> (From update of attachment 94346 [details])
> Test?

How? Are there any tests for the non VCSUtils perl scripts?
Comment 4 Adam Barth 2011-05-22 10:26:18 PDT 
> How? Are there any tests for the non VCSUtils perl scripts?

Dunno.  Maybe we need to add more infrastructure to test-webkitperl ?  Someone else might be willing to r+ your patch without tests, but, personally, I think we should have tests for all this stuff.
Comment 5 Patrick R. Gansterer 2011-05-22 10:28:32 PDT 
(In reply to comment #4)
> > How? Are there any tests for the non VCSUtils perl scripts?
> 
> Dunno.  Maybe we need to add more infrastructure to test-webkitperl ?  Someone else might be willing to r+ your patch without tests, but, personally, I think we should have tests for all this stuff.

I'm not against the tests, but I don't want to write the whole test infrastructure. :-/
Comment 6 WebKit Commit Bot 2011-05-22 11:08:14 PDT 
Comment on attachment 94346 [details]
Patch

Clearing flags on attachment: 94346

Committed r87040: <http://trac.webkit.org/changeset/87040>
Comment 7 WebKit Commit Bot 2011-05-22 11:08:19 PDT 
All reviewed patches have been landed.  Closing bug.