Bug 61244 - Undo operations for a web page linger after page is destroyed
Summary: Undo operations for a web page linger after page is destroyed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Sullivan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-05-21 22:37 PDT by John Sullivan
Modified: 2011-05-22 15:36 PDT (History)
0 users

See Also:

Attachments
Patch to clear edit commands in WebPageProxy::closePage() (1.83 KB, patch)
2011-05-21 22:42 PDT, John Sullivan 		no flags Details | Formatted Diff | Diff
Same patch as last time but without Xcode-initiated tweak to project file. (1.29 KB, patch)
2011-05-21 22:43 PDT, John Sullivan 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Sullivan 2011-05-21 22:37:07 PDT 
Page editing commands are registered with an NSUndoManager on Mac (and a similar mechanism on windows), but there’s no code to tell the NSUndoManager that these operations are no longer valid for Undoing once the page has been closed. This can lead to crashes downstream. In Radar as <rdar://problem/9482856>.
Comment 1 John Sullivan 2011-05-21 22:42:09 PDT 
Created attachment 94335 [details]
Patch to clear edit commands in WebPageProxy::closePage()
Comment 2 John Sullivan 2011-05-21 22:43:29 PDT 
Created attachment 94336 [details]
Same patch as last time but without Xcode-initiated tweak to project file.
Comment 3 John Sullivan 2011-05-22 09:30:27 PDT 
Fixed in <http://trac.webkit.org/changeset/87030>.
Comment 4 John Sullivan 2011-05-22 15:30:23 PDT 
I accidentally checked into a branch instead of trunk, rolled out in 87045.
Comment 5 John Sullivan 2011-05-22 15:36:21 PDT 
Checked into tip of tree in http://trac.webkit.org/changeset/87046