Bug 61241 - REGRESSION (r82144): Icon overlaps text in Twitter message dialog
Summary: REGRESSION (r82144): Icon overlaps text in Twitter message dialog
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Normal
Assignee: mitz@webkit.org
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2011-05-21 13:37 PDT by mitz@webkit.org
Modified: 2011-05-23 07:48 PDT (History)
3 users (show)

See Also:


Attachments
Add midpoints for positioned objects when adding a midpoint behind the current character (21.29 KB, patch)
2011-05-21 13:44 PDT, mitz@webkit.org
darin: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-03 (1.26 MB, application/zip)
2011-05-21 15:01 PDT, WebKit Review Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description mitz@webkit.org 2011-05-21 13:37:45 PDT
REGRESSION (r82144): Icon overlaps text in Twitter message dialog
Comment 1 mitz@webkit.org 2011-05-21 13:38:24 PDT
<rdar://problem/9479926>

Reduction:
X <img style="position: absolute;" src="#"> Y
Comment 2 mitz@webkit.org 2011-05-21 13:44:34 PDT
Created attachment 94327 [details]
Add midpoints for positioned objects when adding a midpoint behind the current character
Comment 3 WebKit Review Bot 2011-05-21 15:01:04 PDT
Comment on attachment 94327 [details]
Add midpoints for positioned objects when adding a midpoint behind the current character

Attachment 94327 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8722507

New failing tests:
fast/block/positioning/058.html
Comment 4 WebKit Review Bot 2011-05-21 15:01:08 PDT
Created attachment 94329 [details]
Archive of layout-test-results from ec2-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03  Port: Chromium  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 5 Darin Adler 2011-05-21 21:22:20 PDT
Comment on attachment 94327 [details]
Add midpoints for positioned objects when adding a midpoint behind the current character

View in context: https://bugs.webkit.org/attachment.cgi?id=94327&action=review

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:1777
> +void TrailingObjects::updateMidpointsForTrailingBoxes(LineMidpointState& lineMidpointState, const InlineIterator& lBreak, bool mergeWithLineBreak)

Both call sites are passing constants, and the false and true at the call sites are completely opaque, so this is one of those cases where an enum would make things clearer than a bool.
Comment 6 mitz@webkit.org 2011-05-21 21:46:39 PDT
Fixed in r87026. <http://trac.webkit.org/changeset/87026>
Comment 7 Ademar Reis 2011-05-23 07:48:10 PDT
Revision r87026 cherry-picked into qtwebkit-2.2 with commit c4e7010 <http://gitorious.org/webkit/qtwebkit/commit/c4e7010>