WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
61238
Share more code in PathTraversalState
https://bugs.webkit.org/show_bug.cgi?id=61238
Summary
Share more code in PathTraversalState
Dirk Schulze
Reported
2011-05-20 22:56:19 PDT
Share more code in PathTraversalState.
Attachments
Patch
(5.89 KB, patch)
2011-05-20 23:31 PDT
,
Dirk Schulze
zimmermann
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dirk Schulze
Comment 1
2011-05-20 23:31:37 PDT
Created
attachment 94322
[details]
Patch
Nikolas Zimmermann
Comment 2
2011-05-20 23:34:40 PDT
Comment on
attachment 94322
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=94322&action=review
Looks good, r=me.
> Source/WebCore/platform/graphics/PathTraversalState.cpp:209 > + if (m_action == TraversalSegmentAtLength > + && m_totalLength >= m_desiredLength)
No need to wrap the line here, eh?
> Source/WebCore/platform/graphics/PathTraversalState.cpp:214 > + if ((m_action == TraversalPointAtLength > + || m_action == TraversalNormalAngleAtLength) > + && m_totalLength >= m_desiredLength) {
Ditto?
> Source/WebCore/platform/graphics/PathTraversalState.h:50 > + void finalizeSegmentCalculation();
How about "processSegment" ?
Dirk Schulze
Comment 3
2011-05-20 23:44:24 PDT
Committed
r87011
: <
http://trac.webkit.org/changeset/87011
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug