Bug 61238 - Share more code in PathTraversalState
Summary: Share more code in PathTraversalState
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Schulze
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-20 22:56 PDT by Dirk Schulze
Modified: 2011-05-20 23:44 PDT (History)
1 user (show)

See Also:


Attachments
Patch (5.89 KB, patch)
2011-05-20 23:31 PDT, Dirk Schulze
zimmermann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2011-05-20 22:56:19 PDT
Share more code in PathTraversalState.
Comment 1 Dirk Schulze 2011-05-20 23:31:37 PDT
Created attachment 94322 [details]
Patch
Comment 2 Nikolas Zimmermann 2011-05-20 23:34:40 PDT
Comment on attachment 94322 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=94322&action=review

Looks good, r=me.

> Source/WebCore/platform/graphics/PathTraversalState.cpp:209
> +    if (m_action == TraversalSegmentAtLength
> +        && m_totalLength >= m_desiredLength)

No need to wrap the line here, eh?

> Source/WebCore/platform/graphics/PathTraversalState.cpp:214
> +    if ((m_action == TraversalPointAtLength
> +        || m_action == TraversalNormalAngleAtLength)
> +        && m_totalLength >= m_desiredLength) {

Ditto?

> Source/WebCore/platform/graphics/PathTraversalState.h:50
> +    void finalizeSegmentCalculation();

How about "processSegment" ?
Comment 3 Dirk Schulze 2011-05-20 23:44:24 PDT
Committed r87011: <http://trac.webkit.org/changeset/87011>