Bug 61236 - [chromium] Updating chromium DEPS
Summary: [chromium] Updating chromium DEPS
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2011-05-20 22:00 PDT by Greg Simon
Modified: 2011-05-22 23:08 PDT (History)
3 users (show)

See Also:

Patch (994 bytes, patch)
2011-05-20 22:01 PDT, Greg Simon
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Simon 2011-05-20 22:00:32 PDT
[chromium] Updating chromium DEPS
Comment 1 Greg Simon 2011-05-20 22:01:57 PDT
Created attachment 94318 [details]
Comment 2 Greg Simon 2011-05-21 19:50:09 PDT
Rolling chromium DEPS to pick up the ScopedTempDir export from webkit_support so it can be used in chromium LayoutTests.
Comment 3 Darin Fisher (:fishd, Google) 2011-05-21 21:40:08 PDT
Comment on attachment 94318 [details]


but we probably dont want code in the webkit repository to depend on ScopedTempDir.
it would make it very painful if someone ever changed that class in an incompatible 
way.  how would the average chromium hacker know to fixup webkit?  and if they did
know they would then have to deal with the circular dependency.  (hard to roll
webkit w/o things being temporarily broken .)

the contents of webkit_support.h mostly encapsulates the extent of the circular deps 
which we have.  if you dont want to copy code into webkit, then consider exposing 
the "algorithm" of interest as new functions in webkit_support.h.
Comment 4 Greg Simon 2011-05-21 21:46:48 PDT
The current application is for a LayoutTest so the temp dir does not get filled up. There are not enough primitives in platform/FileSystem.h to do this sort of work entirely in WebCore.

However, now that this API is set up in webkit_support its impl can be changed (only in chrome) so it does not use ScopedTempDir to avoid the problems you mention.
Comment 5 Fumitoshi Ukai 2011-05-22 23:07:57 PDT
Comment on attachment 94318 [details]

Clearing flags on attachment: 94318

Committed r87050: <http://trac.webkit.org/changeset/87050>
Comment 6 Fumitoshi Ukai 2011-05-22 23:08:05 PDT
All reviewed patches have been landed.  Closing bug.