Bug 61231 – Move EventQueue's Document-specific methods to a subclass

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: New Bugs

[David Grogan]

Move EventQueue's Document-specific methods to a subclass

[David Grogan]

Created attachment 94307 [details]
Patch

[David Grogan]

Dave,

This is the refactoring we talked about around https://bugs.webkit.org/show_bug.cgi?id=57789#c8.  Could you take a look when you get a chance?

[Early Warning System Bot]

Comment on attachment 94307 [details]
Patch

Attachment 94307 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/8723329

[David Grogan]

Created attachment 94312 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 94307 [details]
Patch

Attachment 94307 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/8723332

[David Grogan]

Created attachment 94316 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 94312 [details]
Patch

Attachment 94312 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/8718689

[David Grogan]

Created attachment 94320 [details]
Patch

[David Levin]

Comment on attachment 94320 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=94320&action=review

> Source/WebCore/dom/EventQueue.cpp:64
> +            eventTarget->toDOMWindow()->dispatchEvent(event, /* PassRefPtr<EventTarget> */ 0);

Instead of putting in this comment and using an implicit conversion, just put in PassRefPtr<EventTarget>(). (We'll likely want to remove the implicit constructor anyway eventually like we did for OwnPtr.)

[David Grogan]

Created attachment 94462 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 94462 [details]
Patch

Rejecting attachment 94462 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'build'..." exit_code: 2

Last 500 characters of output:
E_APP_SUPPORT_DIR /Developer/Library/Xcode
    setenv XCODE_VERSION_ACTUAL 0322
    setenv XCODE_VERSION_MAJOR 0300
    setenv XCODE_VERSION_MINOR 0320
    setenv YACC /Developer/usr/bin/yacc
    /bin/sh -c /mnt/git/webkit-commit-queue/WebKitBuild/WebCore.build/Debug/WebCore.build/Script-5DF50887116F3077005202AB.sh

** BUILD FAILED **


The following build commands failed:
WebCore:
	Ld /mnt/git/webkit-commit-queue/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore normal x86_64
(1 failure)


Full output: http://queues.webkit.org/results/8729329

[David Levin]

Undefined symbols:
  "__ZN7WebCore18DocumentEventQueue28enqueueOrDispatchScrollEventEN3WTF10PassRefPtrINS_4NodeEEENS0_21ScrollEventTargetTypeE", referenced from:
      __ZN7WebCore12EventHandler15sendScrollEventEv in EventHandler.o
      __ZN7WebCore11RenderLayer8scrollToEii in RenderLayer.o
      __ZN7WebCore13RenderListBox8scrollToEi in RenderListBox.o
  "__ZN7WebCore18DocumentEventQueue6createEPNS_22ScriptExecutionContextE", referenced from:
      __ZN7WebCore8DocumentC1EPNS_5FrameERKNS_4KURLEbb in Document.o
      __ZN7WebCore8DocumentC2EPNS_5FrameERKNS_4KURLEbb in Document.o
ld: symbol(s) not found
collect2: ld returned 1 exit status

[David Grogan]

57789 took care of this

*** This bug has been marked as a duplicate of bug 57789 ***