Bug 61226 - AudioBufferSourceNode noteOff() method must respect scheduling time
Summary: AudioBufferSourceNode noteOff() method must respect scheduling time
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-20 16:49 PDT by Chris Rogers
Modified: 2011-05-21 02:42 PDT (History)
2 users (show)

See Also:

Attachments
Patch (6.96 KB, patch)
2011-05-20 17:09 PDT, Chris Rogers 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2011-05-20 16:49:53 PDT 
AudioBufferSourceNode noteOff() method must respect scheduling time
Comment 1 Chris Rogers 2011-05-20 17:09:46 PDT 
Created attachment 94296 [details]
Patch
Comment 2 Kenneth Russell 2011-05-20 17:59:14 PDT 
Comment on attachment 94296 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=94296&action=review

Looks fine. One comment about testing.

> Source/WebCore/ChangeLog:8
> +        No new tests since audio API is not yet implemented.

Now that you have a mechanism for rendering to a buffer, would it make sense to start writing layout tests?
Comment 3 Chris Rogers 2011-05-20 19:18:06 PDT 
Hi Ken, I'm still working with Dirk Pranke (currently on vacation) to get everything landed in ORWT and NWRT so I can get the layout tests going.
Comment 4 WebKit Commit Bot 2011-05-21 02:42:21 PDT 
Comment on attachment 94296 [details]
Patch

Clearing flags on attachment: 94296

Committed r87013: <http://trac.webkit.org/changeset/87013>
Comment 5 WebKit Commit Bot 2011-05-21 02:42:26 PDT 
All reviewed patches have been landed.  Closing bug.