Bug 61200 - [Qt] The Qt WebKit Symbian .def file needs to be updated so Symbian will build
Summary: [Qt] The Qt WebKit Symbian .def file needs to be updated so Symbian will build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: S60 Hardware S60 3rd edition
: P3 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2011-05-20 11:16 PDT by Joe Wild
Modified: 2011-07-01 14:12 PDT (History)
5 users (show)

See Also:


Attachments
Updated Qt Webkit Symbian .def file to allow Symibian to build (2.24 KB, patch)
2011-05-20 11:26 PDT, Joe Wild
no flags Details | Formatted Diff | Diff
Revert r87060 as it broke compatibility with QtWebKit 2.1 release (3.42 KB, patch)
2011-06-23 08:44 PDT, Joe Wild
no flags Details | Formatted Diff | Diff
Revert r87060 as it broke compatibility with QtWebKit 2.1 release (3.45 KB, patch)
2011-06-23 13:23 PDT, Joe Wild
no flags Details | Formatted Diff | Diff
Updated Qt Webkit Symbian .def file to allow QtWebKit2.2 on Symibian to build (2.61 KB, patch)
2011-07-01 06:51 PDT, jade han
no flags Details | Formatted Diff | Diff
Updated Qt Webkit Symbian .def file to allow QtWebKit2.2 Tools directory on Symibian to build (3.16 KB, patch)
2011-07-01 13:04 PDT, jade han
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joe Wild 2011-05-20 11:16:47 PDT
The Symbian only .def file, Source/WebKit/qt/symbian/eabi/QtWebKitu.def needs to be updated
so that we can build Qt WebKit on Symbian.

I will submit a small patch shortly.
Comment 1 Joe Wild 2011-05-20 11:26:41 PDT
Created attachment 94246 [details]
Updated Qt Webkit Symbian .def file to allow Symibian to build
Comment 2 WebKit Commit Bot 2011-05-23 01:14:21 PDT
Comment on attachment 94246 [details]
Updated Qt Webkit Symbian .def file to allow Symibian to build

Clearing flags on attachment: 94246

Committed r87060: <http://trac.webkit.org/changeset/87060>
Comment 3 WebKit Commit Bot 2011-05-23 01:14:26 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Ademar Reis 2011-05-23 07:38:17 PDT
Revision r87060 cherry-picked into qtwebkit-2.2 with commit 8385385 <http://gitorious.org/webkit/qtwebkit/commit/8385385>
Comment 5 Laszlo Gombos 2011-06-16 10:51:24 PDT
Note: - This bug/commit is to follow-up on this change http://trac.webkit.org/changeset/80319
Comment 6 Laszlo Gombos 2011-06-16 13:28:28 PDT
This commit break compatibility with the 2.1 QtWebKit release as it changes the mapping of already released ordinal numbers to symbols. This bug needs to be reopened (I do not seem to have privileges to do that).
Comment 7 Joel Parks 2011-06-22 07:43:55 PDT
reopening
Comment 8 Joe Wild 2011-06-23 08:44:15 PDT
Created attachment 98354 [details]
Revert r87060 as it broke compatibility with QtWebKit 2.1 release
Comment 9 Joe Wild 2011-06-23 13:23:28 PDT
Created attachment 98390 [details]
Revert r87060 as it broke compatibility with QtWebKit 2.1 release 

Some minor cleanup.
Comment 10 Laszlo Gombos 2011-06-23 14:10:25 PDT
Comment on attachment 98390 [details]
Revert r87060 as it broke compatibility with QtWebKit 2.1 release 

r=me.
Comment 11 WebKit Review Bot 2011-06-23 15:02:59 PDT
Comment on attachment 98390 [details]
Revert r87060 as it broke compatibility with QtWebKit 2.1 release 

Clearing flags on attachment: 98390

Committed r89621: <http://trac.webkit.org/changeset/89621>
Comment 12 WebKit Review Bot 2011-06-23 15:03:05 PDT
All reviewed patches have been landed.  Closing bug.
Comment 13 Ademar Reis 2011-06-27 06:59:31 PDT
Revision r89621 cherry-picked into qtwebkit-2.2 with commit 50b8e14 <http://gitorious.org/webkit/qtwebkit/commit/50b8e14>
Comment 14 jade han 2011-07-01 06:51:52 PDT
Created attachment 99468 [details]
Updated Qt Webkit Symbian .def file to allow QtWebKit2.2 on Symibian to build
Comment 15 Ademar Reis 2011-07-01 07:07:21 PDT
(In reply to comment #14)
> Created an attachment (id=99468) [details]
> Updated Qt Webkit Symbian .def file to allow QtWebKit2.2 on Symibian to build

This bug is RESOLVED/FIXED, so should it be reopen? (I assume that the previous patch just reverted the change and this one is fixing it for real, is that right?)

Please reopen if that's the case.
Comment 16 Laszlo Gombos 2011-07-01 07:19:40 PDT
Reopen to add more symbols on top of the previously landed patch.
Comment 17 Laszlo Gombos 2011-07-01 07:20:18 PDT
Comment on attachment 99468 [details]
Updated Qt Webkit Symbian .def file to allow QtWebKit2.2 on Symibian to build

LGTM (for both trunk and 2.2 branch).
Comment 18 WebKit Review Bot 2011-07-01 07:29:24 PDT
Comment on attachment 99468 [details]
Updated Qt Webkit Symbian .def file to allow QtWebKit2.2 on Symibian to build

Clearing flags on attachment: 99468

Committed r90227: <http://trac.webkit.org/changeset/90227>
Comment 19 WebKit Review Bot 2011-07-01 07:29:30 PDT
All reviewed patches have been landed.  Closing bug.
Comment 20 Joel Parks 2011-07-01 07:38:40 PDT
(In reply to comment #17)
> (From update of attachment 99468 [details])
> LGTM (for both trunk and 2.2 branch).

so I am adding blocks 55055
Comment 21 Ademar Reis 2011-07-01 07:46:50 PDT
Revision r90227 cherry-picked into qtwebkit-2.2 with commit 2b44c16 <http://gitorious.org/webkit/qtwebkit/commit/2b44c16>
Comment 22 Laszlo Gombos 2011-07-01 13:01:38 PDT
Reopen as QtWebKit now builds for Symbian but the Tools directory is failing because some symbols are still not exported that are needed for Tools.
Comment 23 Ademar Reis 2011-07-01 13:04:49 PDT
:-)
Comment 24 jade han 2011-07-01 13:04:56 PDT
Created attachment 99511 [details]
Updated Qt Webkit Symbian .def file to allow QtWebKit2.2 Tools directory on Symibian to build
Comment 25 Laszlo Gombos 2011-07-01 13:23:20 PDT
Comment on attachment 99511 [details]
Updated Qt Webkit Symbian .def file to allow QtWebKit2.2 Tools directory on Symibian to build

great, thanks !
Comment 26 WebKit Review Bot 2011-07-01 14:09:16 PDT
Comment on attachment 99511 [details]
Updated Qt Webkit Symbian .def file to allow QtWebKit2.2 Tools directory on Symibian to build

Clearing flags on attachment: 99511

Committed r90276: <http://trac.webkit.org/changeset/90276>
Comment 27 WebKit Review Bot 2011-07-01 14:09:21 PDT
All reviewed patches have been landed.  Closing bug.
Comment 28 Ademar Reis 2011-07-01 14:12:01 PDT
Revision r90276 cherry-picked into qtwebkit-2.2 with commit e3377c0 <http://gitorious.org/webkit/qtwebkit/commit/e3377c0>