Bug 61187 - [Qt][V8] Enable ScriptController::disableEval functionality in QtWebkit-V8 build
Summary: [Qt][V8] Enable ScriptController::disableEval functionality in QtWebkit-V8 build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-20 06:33 PDT by Peter Varga
Modified: 2011-06-21 09:00 PDT (History)
4 users (show)

See Also:

Attachments
proposed patch (1.88 KB, patch)
2011-06-21 07:58 PDT, Peter Varga 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Varga 2011-05-20 06:33:41 PDT 
This functionality has been disabled in QtWebkit-V8 build because qtscript-staging's shipped version of
V8's API doesn't provide the Context::AllowCodeGenerationFromStrings() method yet.

It is in V8 since http://code.google.com/p/v8/source/detail?r=7753

This functionality will be enabled at the next update of the qtscript-staging's V8 fork.
Comment 1 Peter Varga 2011-06-21 07:58:54 PDT 
Created attachment 97989 [details]
proposed patch

The QtScript's V8 is up-to-date now. We can enable this functionality.
Comment 2 Andreas Kling 2011-06-21 08:18:12 PDT 
Comment on attachment 97989 [details]
proposed patch

rs=me
Comment 3 WebKit Review Bot 2011-06-21 09:00:18 PDT 
Comment on attachment 97989 [details]
proposed patch

Clearing flags on attachment: 97989

Committed r89359: <http://trac.webkit.org/changeset/89359>
Comment 4 WebKit Review Bot 2011-06-21 09:00:23 PDT 
All reviewed patches have been landed.  Closing bug.