Bug 61172 - Fix style errors in DumpRenderTree/chromium/
Summary: Fix style errors in DumpRenderTree/chromium/
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P5 Trivial
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-20 01:08 PDT by Kent Tamura
Modified: 2011-05-20 01:48 PDT (History)
1 user (show)

See Also:

Attachments
Patch (62.79 KB, patch)
2011-05-20 01:09 PDT, Kent Tamura 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2011-05-20 01:08:07 PDT 
Fix style errors in DumpRenderTree/chromium/
Comment 1 Kent Tamura 2011-05-20 01:09:29 PDT 
Created attachment 94186 [details]
Patch
Comment 2 Ryosuke Niwa 2011-05-20 01:41:23 PDT 
Comment on attachment 94186 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=94186&action=review

> Tools/DumpRenderTree/chromium/DumpRenderTree.cpp:263
> +        // It may have references to not-yet-cleaned up windows. By cleaning up
> +        // here we help purify reports.

It seems like we can fit all of these two lines in one line.
Comment 3 Kent Tamura 2011-05-20 01:46:38 PDT 
Comment on attachment 94186 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=94186&action=review

Thank you for reviewing.

>> Tools/DumpRenderTree/chromium/DumpRenderTree.cpp:263
>> +        // here we help purify reports.
> 
> It seems like we can fit all of these two lines in one line.

Yes.  But I don't like a looong comment line.
Comment 4 Kent Tamura 2011-05-20 01:48:24 PDT 
Comment on attachment 94186 [details]
Patch

Clearing flags on attachment: 94186

Committed r86930: <http://trac.webkit.org/changeset/86930>
Comment 5 Kent Tamura 2011-05-20 01:48:31 PDT 
All reviewed patches have been landed.  Closing bug.