Bug 61171 - Apply the ParallelJobs support to FEConvolveMatrix
Summary: Apply the ParallelJobs support to FEConvolveMatrix
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-20 00:42 PDT by Andras Piroska
Modified: 2011-05-20 01:54 PDT (History)
4 users (show)

See Also:

Attachments
Apply the ParallelJobs support to FEConvolveMatrix (8.71 KB, patch)
2011-05-20 01:05 PDT, Andras Piroska 		zimmermann: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andras Piroska 2011-05-20 00:42:48 PDT 
The FEConvolveMatrix filter of SVG can consume lots of resources if it is
applied to a large area. The computation can be distributed to multiple
cores if the architecture supports.
The average performance progression is 20-30% on dual-core machines.
Comment 1 Andras Piroska 2011-05-20 01:05:29 PDT 
Created attachment 94185 [details]
Apply the ParallelJobs support to FEConvolveMatrix
Comment 2 Nikolas Zimmermann 2011-05-20 01:27:11 PDT 
Comment on attachment 94185 [details]
Apply the ParallelJobs support to FEConvolveMatrix

View in context: https://bugs.webkit.org/attachment.cgi?id=94185&action=review

Looks great, r=me.

> Source/WebCore/platform/graphics/filters/FEConvolveMatrix.cpp:258
> +    for (int y = yEnd + 1; y>yStart; --y) {
>          for (int x = clipRight + 1; x > 0; --x) {

Style: y > yStart, please.
Comment 3 Gabor Loki 2011-05-20 01:54:39 PDT 
Landed in http://trac.webkit.org/changeset/86931