Bug 61164 - [chromium] Fix division by zero in TilingData for boundary case texture sizes
Summary: [chromium] Fix division by zero in TilingData for boundary case texture sizes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrienne Walker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-19 19:03 PDT by Adrienne Walker
Modified: 2011-05-23 13:40 PDT (History)
4 users (show)

See Also:

Attachments
Patch (6.25 KB, patch)
2011-05-19 19:05 PDT, Adrienne Walker 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrienne Walker 2011-05-19 19:03:23 PDT 
[chromium] Fix division by zero in TilingData for boundary case texture sizes
Comment 1 Adrienne Walker 2011-05-19 19:05:17 PDT 
Created attachment 94157 [details]
Patch
Comment 2 Adrienne Walker 2011-05-19 19:09:39 PDT 
This fixes this crasher: http://crash/reportdetail?reportid=139f0688bc41a480

The new test cases repro the division by zero without the corresponding code fix.
Comment 3 James Robinson 2011-05-19 19:17:22 PDT 
Comment on attachment 94157 [details]
Patch

Do you know how to repro this with a web page?
Comment 4 Adrienne Walker 2011-05-19 19:41:20 PDT 
(In reply to comment #3)
> (From update of attachment 94157 [details])
> Do you know how to repro this with a web page?

I suspect that any composited 2xY layer would cause this issue, where Y <= 512.  ContentLayerChromium would set the tile size to be 2x2 because it's small and would ask for border texels in the tiler because it's on a transformed layer.  TilingData's computeNumTiles properly handles this case and avoids the division by zero, but tileXIndexFromSrcCoord does not.
Comment 5 Vincent Scheib 2011-05-19 23:21:50 PDT 
Comment on attachment 94157 [details]
Patch

LGTM
Comment 6 WebKit Commit Bot 2011-05-23 13:40:35 PDT 
Comment on attachment 94157 [details]
Patch

Clearing flags on attachment: 94157

Committed r87094: <http://trac.webkit.org/changeset/87094>
Comment 7 WebKit Commit Bot 2011-05-23 13:40:40 PDT 
All reviewed patches have been landed.  Closing bug.