Bug 61146 - Change RenderBlock hit testing to use IntPoint instead x,y pair
Summary: Change RenderBlock hit testing to use IntPoint instead x,y pair
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Emil A Eklund
URL:
Keywords:
Depends on:
Blocks: 60318
  Show dependency tree / graph
 
Reported: 2011-05-19 14:39 PDT by Emil A Eklund
Modified: 2011-05-23 15:15 PDT (History)
5 users (show)

See Also:

Attachments
Patch (12.66 KB, patch)
2011-05-19 14:45 PDT, Emil A Eklund 		no flags Details | Formatted Diff | Diff
Patch for landing (12.59 KB, patch)
2011-05-23 12:16 PDT, Emil A Eklund 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2011-05-19 14:39:41 PDT 
Change the hit testing code in RenderBlock to take an IntPoint instead of a pair of ints for the x,y position.
Comment 1 Emil A Eklund 2011-05-19 14:45:30 PDT 
Created attachment 94120 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-05-21 06:53:58 PDT 
Comment on attachment 94120 [details]
Patch

Ok
Comment 3 WebKit Commit Bot 2011-05-21 06:55:52 PDT 
Comment on attachment 94120 [details]
Patch

Rejecting attachment 94120 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'apply-..." exit_code: 2

Last 500 characters of output:
p
Hunk #2 succeeded at 3909 with fuzz 1.
Hunk #7 FAILED at 4014.
1 out of 8 hunks FAILED -- saving rejects to file Source/WebCore/rendering/RenderBlock.cpp.rej
patching file Source/WebCore/rendering/RenderBlock.h
Hunk #1 succeeded at 584 (offset 11 lines).
patching file Source/WebCore/rendering/RenderListBox.cpp
patching file Source/WebCore/rendering/RenderListBox.h

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/8716909
Comment 4 Emil A Eklund 2011-05-23 12:16:35 PDT 
Created attachment 94454 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2011-05-23 15:15:30 PDT 
Comment on attachment 94454 [details]
Patch for landing

Clearing flags on attachment: 94454

Committed r87101: <http://trac.webkit.org/changeset/87101>
Comment 6 WebKit Commit Bot 2011-05-23 15:15:35 PDT 
All reviewed patches have been landed.  Closing bug.