Bug 61131 – [V8] Explicitly mark objects with complex GC rules.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Vitaly Repeshko]

[V8] Explicitly mark objects with complex GC rules.

[Vitaly Repeshko]

Created attachment 94084 [details]
patch

[Vitaly Repeshko]

Note, this needs V8 r7923 to build.

[WebKit Review Bot]

Comment on attachment 94084 [details]
patch

Attachment 94084 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8716369

[WebKit Review Bot]

Comment on attachment 94084 [details]
patch

Attachment 94084 [details] did not pass cr-mac-ews (chromium):
Output: http://queues.webkit.org/results/8716387

[anton muhin]

Comment on attachment 94084 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=94084&action=review

LGTM!  Very nice

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:239
> +            next if ($parent eq "EventTarget");

nit: I am not sure we put condition into parents in this file, I think preferred style is next if $parent eq "EventTarget"

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:291
> +            next if ($parent eq "EventTarget");

ditto nitto

[Vitaly Repeshko]

Created attachment 94215 [details]
patch

[Vitaly Repeshko]

Anton, thanks for having a look. Nits fixed.

[Adam Barth]

Comment on attachment 94215 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=94215&action=review

That came out really nicely.

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:235
> +    my $hasDependentLifetime = $dataNode->extendedAttributes->{"V8DependentLifetime"} || IsActiveDomType($interfaceName) || $className =~ /SVG/;

$className =~ /SVG/;

sad face

[Vitaly Repeshko]

	M	Source/WebCore/ChangeLog
	M	Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
	M	Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp
	M	Source/WebCore/bindings/scripts/test/V8/V8TestInterface.h
	M	Source/WebCore/bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp
	M	Source/WebCore/bindings/scripts/test/V8/V8TestMediaQueryListListener.h
	M	Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp
	M	Source/WebCore/bindings/scripts/test/V8/V8TestObj.h
	M	Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp
	M	Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h
	M	Source/WebCore/css/CSSRule.idl
	M	Source/WebCore/css/CSSRuleList.idl
	M	Source/WebCore/css/CSSStyleDeclaration.idl
	M	Source/WebCore/css/CSSValue.idl
	M	Source/WebCore/css/StyleSheet.idl
	M	Source/WebCore/css/StyleSheetList.idl
	M	Source/WebCore/dom/DOMImplementation.idl
	M	Source/WebCore/dom/Node.idl
Committed r87063