Bug 61128 - Fix GraphicsContext3DQt.cpp compile error
Summary: Fix GraphicsContext3DQt.cpp compile error
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2011-05-19 08:36 PDT by Andrew Wason
Modified: 2011-05-19 13:40 PDT (History)
2 users (show)

See Also:

Fix compilation (1.22 KB, patch)
2011-05-19 08:39 PDT, Andrew Wason
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Wason 2011-05-19 08:36:38 PDT
GraphicsContext3DQt.cpp is failing to compile:

../../../Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp: In constructor 'WebCore::GraphicsContext3D::GraphicsContext3D(WebCore::GraphicsContext3D::Attributes, WebCore::HostWindow*, bool)':
../../../Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:692: error: no match for 'operator=' in '((WebCore::GraphicsContext3D*)this)->WebCore::GraphicsContext3D::m_internal = 0'
../../../Source/JavaScriptCore/wtf/OwnPtr.h:131: note: candidates are: WTF::OwnPtr<T>& WTF::OwnPtr<T>::operator=(const WTF::PassOwnPtr<T>&) [with T = WebCore::GraphicsContext3DInternal]
../../../Source/JavaScriptCore/wtf/OwnPtr.h:72: note:                 WTF::OwnPtr<T>& WTF::OwnPtr<T>::operator=(std::nullptr_t) [with T = WebCore::GraphicsContext3DInternal]
../../../Source/JavaScriptCore/wtf/OwnPtr.h:83: note:                 WTF::OwnPtr<T>& WTF::OwnPtr<T>::operator=(const WTF::OwnPtr<T>&) [with T = WebCore::GraphicsContext3DInternal]

Will attach a patch.
Comment 1 Andrew Wason 2011-05-19 08:39:55 PDT
Created attachment 94072 [details]
Fix compilation
Comment 2 Darin Adler 2011-05-19 09:31:58 PDT
Comment on attachment 94072 [details]
Fix compilation

OK. We slightly prefer "= nullptr" to clear(), but the fix is fine either way.
Comment 3 WebKit Commit Bot 2011-05-19 11:39:25 PDT
Comment on attachment 94072 [details]
Fix compilation

Clearing flags on attachment: 94072

Committed r86861: <http://trac.webkit.org/changeset/86861>
Comment 4 WebKit Commit Bot 2011-05-19 11:39:29 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Ademar Reis 2011-05-19 13:40:53 PDT
Revision r86861 cherry-picked into qtwebkit-2.2 with commit 863c88a <http://gitorious.org/webkit/qtwebkit/commit/863c88a>