Bug 61118 - [GTK] fullscreen/full-screen-keyboard-enabled.html fails
Summary: [GTK] fullscreen/full-screen-keyboard-enabled.html fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, LayoutTestFailure
Depends on:
Blocks:
 
Reported: 2011-05-19 03:17 PDT by Philippe Normand
Modified: 2015-05-07 17:46 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2011-05-19 03:17:36 PDT 
Because our ChromeClient always prohibits enterFullscreen for keyboard events. See http://trac.webkit.org/changeset/82124/trunk/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp

On mac the UIDelegate used by DRT always allows fullscreen, that's why the test passes there. We should do something similar on GTK, allow DRT to override this specific ChromeClient behavior.

Will skip the test on GTK for now.
Comment 1 Philippe Normand 2012-06-15 13:05:31 PDT 
A simpler solution would be to always allow enterFullscreen.
Comment 2 Martin Robinson 2015-05-07 17:46:26 PDT 
Seems okay now.