RESOLVED INVALID61106
check-webkit-style false positive for alphabetical sorting problem 
https://bugs.webkit.org/show_bug.cgi?id=61106
Summary check-webkit-style false positive for alphabetical sorting problem
philippe.beauchamp
Reported 2011-05-18 19:24:21 PDT
Style error is false positive for alphabetical sorting problem. This will flag a style error: #include "HitTestResult.h" #include "HTMLFormElement.h" ^ This will not flag a style error: #include "HTMLPlugInImageElement.h" #include "HistoryItem.h" #include "HitTestResult.h" #include "KURL.h" Lines must be compared in lower case: if previous_header_type == _OTHER_HEADER and previous_line.strip().lower() > line.strip().lower():
Attachments
Proposed Patch (1.35 KB, patch)
2011-05-18 19:27 PDT, philippe.beauchamp 		ap: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
philippe.beauchamp
Comment 1 2011-05-18 19:27:36 PDT
Created attachment 94034 [details] Proposed Patch
Alexey Proskuryakov
Comment 2 2011-05-19 00:35:38 PDT
Comment on attachment 94034 [details] Proposed Patch WebKit style guide says that the sort order is "case sensitive, as done by the command-line sort tool or the Xcode sort selection command".
Note You need to log in before you can comment on or make changes to this bug.