Bug 61078 - Use toHTTPPipeliningPriority() in initializeMaximumHTTPConnectionCountPerHost()
Summary: Use toHTTPPipeliningPriority() in initializeMaximumHTTPConnectionCountPerHost()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on: 57384
Blocks:
  Show dependency tree / graph
 
Reported: 2011-05-18 10:17 PDT by David Kilzer (:ddkilzer)
Modified: 2011-05-18 11:34 PDT (History)
2 users (show)

See Also:

Attachments
Patch v1 (1.69 KB, patch)
2011-05-18 10:38 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
Patch v2 (2.03 KB, patch)
2011-05-18 11:09 PDT, David Kilzer (:ddkilzer) 		joepeck: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2011-05-18 10:17:17 PDT 
Instead of passing a ResourceLoadPriority directly into wkSetHTTPPipeliningMaximumPriority(), we should convert it using Use toHTTPPipeliningPriority().

This should have been done in r82900 for Bug 57384.  <http://trac.webkit.org/changeset/82900>

The method is in Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp.
Comment 1 David Kilzer (:ddkilzer) 2011-05-18 10:38:29 PDT 
Created attachment 93933 [details]
Patch v1
Comment 2 Joseph Pecoraro 2011-05-18 10:40:01 PDT 
Comment on attachment 93933 [details]
Patch v1

r=me. Thanks!
Comment 3 David Kilzer (:ddkilzer) 2011-05-18 11:02:12 PDT 
Comment on attachment 93933 [details]
Patch v1

We should also fix wkSetHTTPPipeliningMinimumFastLanePriority() as well while we're here.
Comment 4 David Kilzer (:ddkilzer) 2011-05-18 11:09:47 PDT 
Created attachment 93939 [details]
Patch v2
Comment 5 Joseph Pecoraro 2011-05-18 11:14:27 PDT 
Comment on attachment 93939 [details]
Patch v2

Oh, excellent. Good catch.
Comment 6 David Kilzer (:ddkilzer) 2011-05-18 11:34:57 PDT 
Committed r86778: <http://trac.webkit.org/changeset/86778>