Bug 61076 - Teach platform/win about window.internals
Summary: Teach platform/win about window.internals
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dimitri Glazkov (Google)
Depends on: 60313
Blocks: 61073
  Show dependency treegraph
Reported: 2011-05-18 10:11 PDT by WebKit Review Bot
Modified: 2011-06-06 05:35 PDT (History)
5 users (show)

See Also:

Patch (31.68 KB, patch)
2011-06-04 04:36 PDT, Dominic Cooney
no flags Details | Formatted Diff | Diff
Fixes tabs in WebKit2.def. (31.72 KB, patch)
2011-06-04 04:41 PDT, Dominic Cooney
dglazkov: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2011-05-18 10:11:31 PDT
Teach platform/win about window.internals
Requested by dglazkov on #webkit.
Comment 1 Dimitri Glazkov (Google) 2011-06-02 14:57:50 PDT
Now that bug 60313 is fixed, this is ripe for adding on Win! :)
Comment 2 Dimitri Glazkov (Google) 2011-06-02 16:03:16 PDT
I was told that Jeff Miller is a total hero who can fix this.
Comment 3 Jeff Miller 2011-06-02 16:26:23 PDT
(In reply to comment #2)
> I was told that Jeff Miller is a total hero who can fix this.

Maybe, but I'm completely unfamiliar with what this feature is.
Comment 4 Dominic Cooney 2011-06-04 04:36:29 PDT
Created attachment 96017 [details]
Comment 5 Dominic Cooney 2011-06-04 04:41:09 PDT
Created attachment 96018 [details]
Fixes tabs in WebKit2.def.
Comment 6 Dimitri Glazkov (Google) 2011-06-04 07:38:57 PDT
Comment on attachment 96018 [details]
Fixes tabs in WebKit2.def.

View in context: https://bugs.webkit.org/attachment.cgi?id=96018&action=review

Yay Dominic!!

Adam, Jeff, Jer -- does this look sane to you?

> Source/WebKit2/win/WebKit2.def:140
> +        ; Re-exports from WebCore for WebCoreTestSupport
> +        ?getCachedDOMStructure@WebCore@@YAPAVStructure@JSC@@PAVJSDOMGlobalObject@1@PBUClassInfo@3@@Z
> +        ?cacheDOMStructure@WebCore@@YAPAVStructure@JSC@@PAVJSDOMGlobalObject@1@PAV23@PBUClassInfo@3@@Z
> +        ?virtualFunctionToPreventWeakVtable@JSDOMWrapper@WebCore@@MAEXXZ

This seems troubling. I didn't realize we'd have to do this for Windows too :(

I wonder if a "safely-export-symbol-across-platform" tool is in the cards for us.
Comment 7 Jer Noble 2011-06-04 09:55:17 PDT
Looks sane enough for me.
Comment 8 Dominic Cooney 2011-06-06 05:35:47 PDT
Committed r88159: <http://trac.webkit.org/changeset/88159>