RESOLVED FIXED 61072
When checking whether the tree is red, the EWS posts a link to the wrong log 
https://bugs.webkit.org/show_bug.cgi?id=61072
Summary When checking whether the tree is red, the EWS posts a link to the wrong log
WebKit Review Bot
Reported 2011-05-18 09:59:49 PDT
When checking whether the tree is red, the EWS posts a link to the wrong log Requested by abarth on #webkit.
Attachments
needs tests (4.13 KB, patch)
2011-05-27 16:58 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (8.58 KB, patch)
2011-05-27 17:20 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-05-27 16:56:56 PDT
Really? Crazy.
Adam Barth
Comment 2 2011-05-27 16:58:59 PDT
Created attachment 95231 [details] needs tests
Adam Barth
Comment 3 2011-05-27 17:02:38 PDT
This is a great example of "if its not tested, its broken". We test that the right type of exception is thrown, but not which of the two possible exceptions of that type it is!
Adam Barth
Comment 4 2011-05-27 17:07:46 PDT
We want assertRaisesRegexp, but that doesn't exist until Python 2.7. :(
Adam Barth
Comment 5 2011-05-27 17:20:20 PDT
Created attachment 95234 [details] Patch
Eric Seidel (no email)
Comment 6 2011-05-27 18:09:25 PDT
Comment on attachment 95234 [details] Patch OK.
WebKit Commit Bot
Comment 7 2011-05-27 21:48:43 PDT
Comment on attachment 95234 [details] Patch Clearing flags on attachment: 95234 Committed r87601: <http://trac.webkit.org/changeset/87601>
WebKit Commit Bot
Comment 8 2011-05-27 21:48:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.