This logic (patch to follow) is supposed to help implement this: http://code.google.com/p/chromium/issues/detail?id=67871
Created attachment 93928 [details] Patch
Comment on attachment 93928 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=93928&action=review > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) Should be no OOPS here. I'll point you to the inspector tests offline so that it was covered. > Source/WebCore/css/CSSStyleSelector.cpp:1994 > +PassRefPtr<CSSRuleList> CSSStyleSelector::styleRulesForElement(Element* e, bool authorOnly, bool includeEmptyRules, CSSRuleFilter filter, unsigned emulateElementPseudoClass) emulatePseudoClassMask ? > Source/WebCore/css/CSSStyleSelector.cpp:2803 > + if (emulateElementPseudoClass != EmulateNone) I'd suggest if (emulatePseudoClassMask & EmulateFocus) return true;
Created attachment 93937 [details] patch
Attachment 93937 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/css/CSSStyleSelector.h:138: The parameter name "filter" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/css/CSSStyleSelector.h:139: The parameter name "filter" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 93938 [details] patch
Created attachment 94591 [details] patch
Created attachment 94783 [details] patch
According to dhyatt, "looks ok although if possible might consider just doing a single check up front rather than adding code to the different cases". I will take over the bug and put together an updated patch.
Created attachment 97427 [details] [PATCH] Suggested solution, dhyatt's comment addressed
Comment on attachment 97427 [details] [PATCH] Suggested solution, dhyatt's comment addressed Attachment 97427 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8883005
Comment on attachment 97427 [details] [PATCH] Suggested solution, dhyatt's comment addressed Attachment 97427 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/8880142
Created attachment 97429 [details] [PATCH] Fix Chromium/Mac builds
Comment on attachment 97429 [details] [PATCH] Fix Chromium/Mac builds r=me
Comment on attachment 97429 [details] [PATCH] Fix Chromium/Mac builds Clearing flags on attachment: 97429 Committed r89132: <http://trac.webkit.org/changeset/89132>
All reviewed patches have been landed. Closing bug.