Bug 61052 - [ORWT]Make --skipped=only option work with parameters with LayoutTests/ prefix
Summary: [ORWT]Make --skipped=only option work with parameters with LayoutTests/ prefix
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-18 07:25 PDT by Chang Shu
Modified: 2011-05-24 10:07 PDT (History)
3 users (show)

See Also:

Attachments
proposed fix (2.37 KB, patch)
2011-05-20 05:17 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chang Shu 2011-05-18 07:25:35 PDT 
I ran the following script:
Tools/Scripts/run-webkit-tests LayoutTests/fast/events --skipped=only
I expected to see only the skipped tests under folder LayoutTests/fast/events to be run. However, the test log (on mac) shows
"Testing 24080 test cases."
Note that this is equivalent to run
Tools/Scripts/run-webkit-tests --skipped=ignore
Normally, running
Tools/Scripts/run-webkit-tests
shows
"Testing 23538 test cases."

However, running the script without sub-folder works as expected:
Tools/Scripts/run-webkit-tests --skipped=only
shows
"Testing 592 test cases."
Comment 1 Csaba Osztrogonác 2011-05-18 07:33:10 PDT 
Unfortunately --skipped=only use too simple algorithm, it compares
the parameters with skipped list entries. 

If you don't add LayoutTests, it works.

But it would be great if it can handle LayoutTests/ prefix ...
Comment 2 Csaba Osztrogonác 2011-05-20 05:17:14 PDT 
Created attachment 94201 [details]
proposed fix

It would make --skipped=only users happier, because
they can use tab completion to find the directory name. :)
Comment 3 Andras Becsi 2011-05-20 05:21:44 PDT 
Comment on attachment 94201 [details]
proposed fix

Some more perl magic. LGTM.
Comment 4 Chang Shu 2011-05-20 06:15:03 PDT 
Thanks, Ossy.
Comment 5 WebKit Commit Bot 2011-05-24 10:07:44 PDT 
Comment on attachment 94201 [details]
proposed fix

Clearing flags on attachment: 94201

Committed r87162: <http://trac.webkit.org/changeset/87162>
Comment 6 WebKit Commit Bot 2011-05-24 10:07:48 PDT 
All reviewed patches have been landed.  Closing bug.