Bug 61052 – [ORWT]Make --skipped=only option work with parameters with LayoutTests/ prefix

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Chang Shu]

I ran the following script:
Tools/Scripts/run-webkit-tests LayoutTests/fast/events --skipped=only
I expected to see only the skipped tests under folder LayoutTests/fast/events to be run. However, the test log (on mac) shows
"Testing 24080 test cases."
Note that this is equivalent to run
Tools/Scripts/run-webkit-tests --skipped=ignore
Normally, running
Tools/Scripts/run-webkit-tests
shows
"Testing 23538 test cases."

However, running the script without sub-folder works as expected:
Tools/Scripts/run-webkit-tests --skipped=only
shows
"Testing 592 test cases."

[Csaba Osztrogonác]

Unfortunately --skipped=only use too simple algorithm, it compares
the parameters with skipped list entries. 

If you don't add LayoutTests, it works.

But it would be great if it can handle LayoutTests/ prefix ...

[Csaba Osztrogonác]

Created attachment 94201 [details]
proposed fix

It would make --skipped=only users happier, because
they can use tab completion to find the directory name. :)

[Andras Becsi]

Comment on attachment 94201 [details]
proposed fix

Some more perl magic. LGTM.

[Chang Shu]

Thanks, Ossy.

[WebKit Commit Bot]

Comment on attachment 94201 [details]
proposed fix

Clearing flags on attachment: 94201

Committed r87162: <http://trac.webkit.org/changeset/87162>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.