FAIL! : tst_QWebPage::testOptionalJSObjects() Compared values are not the same Actual (testFlag(webPage2, QWebSettings::LocalStorageEnabled, "localStorage", true)): 0 Expected (true): 1 Loc: [/ramdisk/qt-linux-release/build/Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp(2295)]
Created attachment 94210 [details] mark failing test cases as expected fail
Comment on attachment 94210 [details] mark failing test cases as expected fail wrong patch
Created attachment 94211 [details] mark failing test cases as expected fail
Attachment 94211 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/qt/ChangeLog', u'Source/WebK..." exit_code: 1 Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:2342: Missing space after , [whitespace/comma] [3] Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:2345: Missing space after , [whitespace/comma] [3] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 94211 [details] mark failing test cases as expected fail cq-, I'll fix the style issue before landing.
Comment on attachment 94211 [details] mark failing test cases as expected fail Landed in http://trac.webkit.org/changeset/86951
I've tried to solve this here: https://bugs.webkit.org/show_bug.cgi?id=58847. There's a patch waiting for review there by the way.
Revision r86951 cherry-picked into qtwebkit-2.2 with commit e34811a <http://gitorious.org/webkit/qtwebkit/commit/e34811a>
(In reply to comment #7) > I've tried to solve this here: https://bugs.webkit.org/show_bug.cgi?id=58847. There's a patch waiting for review there by the way. Even with your patch, the two failures are still there, but they're different than the one originally reported on this bug. The ones currently failing are: FAIL! : tst_QWebPage::testOptionalJSObjects() Compared values are not the same Actual (testFlag(webPage1, QWebSettings::OfflineWebApplicationCacheEnabled, "applicationCache", false)): 1 Expected (false): 0 Loc: [/opt/projects/webkit/qtwebkit-2.2/Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp(2335)] and if we continue (via XFAIL): FAIL! : tst_QWebPage::testOptionalJSObjects() Compared values are not the same Actual (testFlag(webPage1, QWebSettings::OfflineWebApplicationCacheEnabled, "applicationCache", false)): 1 Expected (false): 0 Loc: [/opt/projects/webkit/qtwebkit-2.2/Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp(2338)]
They were failing before: https://bugs.webkit.org/show_bug.cgi?id=29867 Perhaps we should reopen that bug, and close this one as it is a duplicate.
Tests aren't marked as failures now, so they work fine.