Bug 61044 - [Qt] Fix tst_QGraphicsWebView::setPalette(inactiveBG) autotest
Summary: [Qt] Fix tst_QGraphicsWebView::setPalette(inactiveBG) autotest
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexis Menard (darktears)
Keywords: Qt, QtTriaged
Depends on:
Blocks: 38654
  Show dependency treegraph
Reported: 2011-05-18 05:12 PDT by Csaba Osztrogonác
Modified: 2011-05-27 11:23 PDT (History)
5 users (show)

See Also:

Patch (1.84 KB, patch)
2011-05-26 10:18 PDT, Alexis Menard (darktears)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2011-05-18 05:12:11 PDT
Error message with r86748:

FAIL!  : tst_QGraphicsWebView::setPalette(inactiveBG) Compared pointers are not the same
   Actual (QApplication::activeWindow()): (nil)
   Expected (activeView): 0xfffeddd8
   Loc: [/ramdisk/qt-linux-release/build/Source/WebKit/qt/tests/qgraphicswebview/tst_qgraphicswebview.cpp(450)]
Comment 1 Alexis Menard (darktears) 2011-05-26 09:10:01 PDT
Ossy got some news? Is that a flacky test?
Comment 2 Csaba Osztrogonác 2011-05-26 09:18:22 PDT
Yes, it is. Feel free to check the results on the bot and pick up this bug.
Comment 3 Alexis Menard (darktears) 2011-05-26 10:18:27 PDT
Created attachment 95000 [details]
Comment 4 Alexis Menard (darktears) 2011-05-26 10:19:57 PDT
(In reply to comment #3)
> Created an attachment (id=95000) [details]
> Patch

Sounds like more a workaround but if it works. It's a regression on the new bots it seems all of that was working before. Ossy can you test?
Comment 5 Csaba Osztrogonác 2011-05-27 07:30:29 PDT
Comment on attachment 95000 [details]

Unfortunately I can't reproduce this bug locally now,
but it still fails on the buildbot intermittently.

I hope this patch will fix this flakiness. :) So r=me.
Comment 6 WebKit Commit Bot 2011-05-27 08:34:29 PDT
Comment on attachment 95000 [details]

Clearing flags on attachment: 95000

Committed r87514: <http://trac.webkit.org/changeset/87514>
Comment 7 WebKit Commit Bot 2011-05-27 08:34:35 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Ademar Reis 2011-05-27 11:23:07 PDT
Revision r87514 cherry-picked into qtwebkit-2.2 with commit 329d0c6 <http://gitorious.org/webkit/qtwebkit/commit/329d0c6>