there are 4 stages of making detailed heap snapshot. 1) snapshoting 2) loading... 3) parsing... 4) a stage between parsing and the moment when snapshot items appear in the list. it'd be nice to have a text for the fourth stage and a kind of progress indicator for all the stages.
Created attachment 94224 [details] patch
Comment on attachment 94224 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=94224&action=review > Source/WebCore/inspector/front-end/PleaseWaitMessage.js:93 > + if (action) The action will not be called if the message is already visible. r- for this.
Created attachment 94258 [details] comment addressed
(In reply to comment #2) > (From update of attachment 94224 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=94224&action=review > > > Source/WebCore/inspector/front-end/PleaseWaitMessage.js:93 > > + if (action) > > The action will not be called if the message is already visible. r- for this. Really good catch! Fixed.
Comment on attachment 94258 [details] comment addressed View in context: https://bugs.webkit.org/attachment.cgi?id=94258&action=review > Source/WebCore/inspector/front-end/PleaseWaitMessage.js:90 > + listenObject.addEventListener(listenEvent, WebInspector.PleaseWaitMessage.prototype.unlistenAndHide.bind(instance, listenObject, listenEvent), instance); Why no use a shorter notation: instance.unlistenAndHide.bind(instance, listenObject, listenEvent)? Also, you don't need to pass instance as the third parameter since you pass it in bind.
Comment on attachment 94258 [details] comment addressed View in context: https://bugs.webkit.org/attachment.cgi?id=94258&action=review >> Source/WebCore/inspector/front-end/PleaseWaitMessage.js:90 >> + listenObject.addEventListener(listenEvent, WebInspector.PleaseWaitMessage.prototype.unlistenAndHide.bind(instance, listenObject, listenEvent), instance); > > Why no use a shorter notation: instance.unlistenAndHide.bind(instance, listenObject, listenEvent)? Also, you don't need to pass instance as the third parameter since you pass it in bind. Fixed. The third parameter is used by Object.addEventListener / removeEventListener pair of functions to identify the listener, as they can't extract the event handler from the closure passed.
Manually committed http://trac.webkit.org/changeset/87056 2011-05-23 Mikhail Naganov <mnaganov@chromium.org> Reviewed by Yury Semikhatsky. Web Inspector: [Chromium] Show "Please wait" message during initial heap snapshot processing. https://bugs.webkit.org/show_bug.cgi?id=61040 * inspector/front-end/DetailedHeapshotView.js: (WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged.sort): (WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged): (WebInspector.DetailedHeapshotView.profileCallback): (WebInspector.DetailedHeapshotView.setDataSource): (WebInspector.DetailedHeapshotView): (WebInspector.DetailedHeapshotView.prototype._changeBase.baseProfileLoaded): (WebInspector.DetailedHeapshotView.prototype._changeBase.setDataSource): (WebInspector.DetailedHeapshotView.prototype._changeBase): (WebInspector.DetailedHeapshotView.prototype._changeView.setDataSource): (WebInspector.DetailedHeapshotView.prototype._changeView): * inspector/front-end/PleaseWaitMessage.js: (WebInspector.PleaseWaitMessage.prototype.showAndWaitFor):