Bug 61030 - Web Inspector: switch to Scripts panel is too slow
Summary: Web Inspector: switch to Scripts panel is too slow
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Adaikin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-18 02:20 PDT by Ilya Tikhonovsky
Modified: 2011-05-19 05:44 PDT (History)
12 users (show)

See Also:


Attachments
Patch (7.59 KB, patch)
2011-05-19 03:13 PDT, Andrey Adaikin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2011-05-18 02:20:43 PDT
switch from a panel to scripts panel takes ~1.5sec
most of the time was earned by TextEditorChunkedPanel.resize
Comment 1 Andrey Adaikin 2011-05-18 02:51:19 PDT
AFAIK, Pavel was looking into the same issue, and we were talking about moving the editor into an iframe, because those 1.5 sec seems to be spent in the layout, but not in the JS execution.

Pavel, can you comment on this?
Comment 2 Pavel Feldman 2011-05-18 03:00:59 PDT
(In reply to comment #1)
> AFAIK, Pavel was looking into the same issue, and we were talking about moving the editor into an iframe, because those 1.5 sec seems to be spent in the layout, but not in the JS execution.
> 
> Pavel, can you comment on this?

This particular but is about resize being called on show. But I agree that it does not contribute as much slowness as the style issue.
Comment 3 Andrey Adaikin 2011-05-19 03:13:04 PDT
Created attachment 94056 [details]
Patch
Comment 4 WebKit Commit Bot 2011-05-19 05:44:52 PDT
Comment on attachment 94056 [details]
Patch

Clearing flags on attachment: 94056

Committed r86842: <http://trac.webkit.org/changeset/86842>
Comment 5 WebKit Commit Bot 2011-05-19 05:44:57 PDT
All reviewed patches have been landed.  Closing bug.