RESOLVED FIXED 61026
Don't use DEFINE_STATIC_LOCAL with an unsigned 
https://bugs.webkit.org/show_bug.cgi?id=61026
Summary Don't use DEFINE_STATIC_LOCAL with an unsigned
Pratik Solanki
Reported 2011-05-18 00:28:23 PDT
StorageTracker.cpp has DEFINE_STATIC_LOCAL(const unsigned, fileExtLength, (fileExt.length())); DEFINE_STATIC_LOCAL is meant for objects, not unsigned ints. We can just use static here.
Attachments
Patch (1.47 KB, patch)
2011-05-18 00:32 PDT, Pratik Solanki 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pratik Solanki
Comment 1 2011-05-18 00:32:33 PDT
Created attachment 93879 [details] Patch
Simon Fraser (smfr)
Comment 2 2011-05-18 07:55:02 PDT
I wonder if we could make it compile error to use DEFINE_STATIC_LOCAL on POD types?
Pratik Solanki
Comment 3 2011-05-18 09:13:16 PDT
Committed r86772: <http://trac.webkit.org/changeset/86772>
Note You need to log in before you can comment on or make changes to this bug.