Bug 61021 - valueMissing validity for select elements is lame when selecting a value by a key operation
Summary: valueMissing validity for select elements is lame when selecting a value by a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-17 21:00 PDT by Kent Tamura
Modified: 2011-05-18 02:33 PDT (History)
3 users (show)

See Also:

Attachments
Patch (6.74 KB, patch)
2011-05-17 22:09 PDT, Kent Tamura 		no flags Details | Formatted Diff | Diff
Patch 2 (39.52 KB, patch)
2011-05-18 01:05 PDT, Kent Tamura 		no flags Details | Formatted Diff | Diff
Patch 3 (7.59 KB, patch)
2011-05-18 01:28 PDT, Kent Tamura 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2011-05-17 21:00:32 PDT 
http://code.google.com/p/chromium/issues/detail?id=76257

This doesn't happen on Mac because arrow keys show a popup menu on Mac (ARROW_KEYS_POP_MENU in dom/SelectElement.cpp)
Comment 1 Kent Tamura 2011-05-17 21:08:26 PDT 
Oh, I have found a way to reproduce this problem on Mac.
Comment 2 Kent Tamura 2011-05-17 22:09:38 PDT 
Created attachment 93870 [details]
Patch
Comment 3 Hajime Morrita 2011-05-18 00:39:10 PDT 
Comment on attachment 93870 [details]
Patch

Code looks fine. Can we test item selections using lookahead-search and accesskey? both reaches setSelectedIndex().
Comment 4 Kent Tamura 2011-05-18 01:05:58 PDT 
Created attachment 93882 [details]
Patch 2

Adding an accesskey test
Comment 5 Kent Tamura 2011-05-18 01:07:49 PDT 
(In reply to comment #3)
> (From update of attachment 93870 [details])
> Code looks fine. Can we test item selections using lookahead-search and accesskey? both reaches setSelectedIndex().

I have added an accesskey test.  The previous patch already had a test for lookahead search.
Comment 6 Kent Tamura 2011-05-18 01:28:27 PDT 
Created attachment 93884 [details]
Patch 3

Remove unnecessary change
Comment 7 Hajime Morrita 2011-05-18 01:34:02 PDT 
Comment on attachment 93884 [details]
Patch 3

Kent-san, thank you for adding tests!
Comment 8 Kent Tamura 2011-05-18 01:40:39 PDT 
Thank you for reviewing!
Comment 9 WebKit Commit Bot 2011-05-18 02:33:53 PDT 
Comment on attachment 93884 [details]
Patch 3

Clearing flags on attachment: 93884

Committed r86744: <http://trac.webkit.org/changeset/86744>
Comment 10 WebKit Commit Bot 2011-05-18 02:33:58 PDT 
All reviewed patches have been landed.  Closing bug.