NEW 60993
Refactor queues.webkit.org's locktable to deal with LockEntry objects (and teach it about bot_id) 
https://bugs.webkit.org/show_bug.cgi?id=60993
Summary Refactor queues.webkit.org's locktable to deal with LockEntry objects (and te...
Eric Seidel (no email)
Reported 2011-05-17 15:01:44 PDT
Refactor queues.webkit.org's locktable to deal with LockEntry objects (and teach it about bot_id)
Attachments
Patch (15.92 KB, patch)
2011-05-17 15:02 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch (16.91 KB, patch)
2011-05-17 15:08 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-05-17 15:02:30 PDT
Created attachment 93823 [details] Patch
Eric Seidel (no email)
Comment 2 2011-05-17 15:08:59 PDT
Created attachment 93825 [details] Patch
David Levin
Comment 3 2011-05-17 15:15:55 PDT
Comment on attachment 93825 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=93825&action=review I'm so unfamiliar with this code that it would take me a long time to parse this. > Tools/ChangeLog:13 > + It also became clear that we need to clean up who's responsibility s/who's/whose/
Eric Seidel (no email)
Comment 4 2011-05-17 17:20:24 PDT
That's fine. Perfectly valid feedback is always "this is too complicated, you need to do it in smaller pieces". :) I'll see if I can walk through it with Adam in person tomorrow.
Adam Barth
Comment 5 2011-10-14 22:46:12 PDT
Comment on attachment 93825 [details] Patch Clearing review flag to remove this from pending-review. Please feel encouraged to discuss this patch with me in person if you still think there's a problem to solve here.
Note You need to log in before you can comment on or make changes to this bug.