Bug 60993 - Refactor queues.webkit.org's locktable to deal with LockEntry objects (and teach it about bot_id)
Summary: Refactor queues.webkit.org's locktable to deal with LockEntry objects (and te...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-17 15:01 PDT by Eric Seidel (no email)
Modified: 2017-07-18 08:30 PDT (History)
3 users (show)

See Also:

Attachments
Patch (15.92 KB, patch)
2011-05-17 15:02 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
Patch (16.91 KB, patch)
2011-05-17 15:08 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2011-05-17 15:01:44 PDT 
Refactor queues.webkit.org's locktable to deal with LockEntry objects (and teach it about bot_id)
Comment 1 Eric Seidel (no email) 2011-05-17 15:02:30 PDT 
Created attachment 93823 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-05-17 15:08:59 PDT 
Created attachment 93825 [details]
Patch
Comment 3 David Levin 2011-05-17 15:15:55 PDT 
Comment on attachment 93825 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=93825&action=review

I'm so unfamiliar with this code that it would take me a long time to parse this.

> Tools/ChangeLog:13
> +        It also became clear that we need to clean up who's responsibility

s/who's/whose/
Comment 4 Eric Seidel (no email) 2011-05-17 17:20:24 PDT 
That's fine.  Perfectly valid feedback is always "this is too complicated, you need to do it in smaller pieces". :) I'll see if I can walk through it with Adam in person tomorrow.
Comment 5 Adam Barth 2011-10-14 22:46:12 PDT 
Comment on attachment 93825 [details]
Patch

Clearing review flag to remove this from pending-review.  Please feel encouraged to discuss this patch with me in person if you still think there's a problem to solve here.