Bug 60982 - Exiting full screen will leave up invisible full-screen window, blocking all mouse clicks.
Summary: Exiting full screen will leave up invisible full-screen window, blocking all ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.6
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-05-17 13:31 PDT by Jer Noble
Modified: 2011-05-17 23:16 PDT (History)
0 users

See Also:


Attachments
Patch (9.58 KB, patch)
2011-05-17 13:47 PDT, Jer Noble
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2011-05-17 13:31:16 PDT
Exiting full screen will leave up invisible full-screen window, blocking all mouse clicks.
Comment 1 Jer Noble 2011-05-17 13:47:05 PDT
Created attachment 93811 [details]
Patch
Comment 2 Jer Noble 2011-05-17 13:47:19 PDT
<rdar://problem/9455104>
Comment 3 Darin Adler 2011-05-17 18:15:27 PDT
Comment on attachment 93811 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=93811&action=review

> Source/WebKit2/WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:138
> +    if (m_rootLayer && m_rootLayer->children().contains(layer))
>          return;

Seems a little silly to search the root layer for a layer of 0 when this is called with 0. This check could go after the !layer check.
Comment 4 Jer Noble 2011-05-17 23:16:37 PDT
Committed r86738: <http://trac.webkit.org/changeset/86738>