Bug 60979 - SVGRootInlineBox triggers calculateBoundaries twice in layout
Summary: SVGRootInlineBox triggers calculateBoundaries twice in layout
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: Performance
Depends on:
Reported: 2011-05-17 12:35 PDT by Levi Weintraub
Modified: 2011-05-20 00:57 PDT (History)
4 users (show)

See Also:

Patch (6.56 KB, patch)
2011-05-20 00:23 PDT, Leo Yang
zimmermann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2011-05-17 12:35:37 PDT
Within computerPerCharacterLayoutInformation, first layoutChildBoxes is called. This function calls calculateBoundaries on all child boxes. Directly afterwards, layoutRootBox determines the rect for itself based on its children, but instead of using the values just calculated in the previous step, they're re-calculated. There is no early return in calculateBoundaries.
Comment 1 Leo Yang 2011-05-20 00:23:24 PDT
Created attachment 94181 [details]
Comment 2 Nikolas Zimmermann 2011-05-20 00:45:21 PDT
Comment on attachment 94181 [details]

Good catch, r=me, assuming no regressions.
Comment 3 Leo Yang 2011-05-20 00:57:21 PDT
Committed r86927: <http://trac.webkit.org/changeset/86927>