Bug 60966 – Web Inspector: model-based CSS editing does not update @import-ed stylesheet resources

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Alexander Pavlov (apavlov)]

Edit any rule from any stylesheet which is imported as
@import url(...)
and examine the Resources panel. The corresponding resource is not updated and there is no new revision there.

Upstreaming http://code.google.com/p/chromium/issues/detail?id=81838

[Alexander Pavlov (apavlov)]

Created attachment 93890 [details]
[PATCH] Suggested fix

[Pavel Feldman]

Comment on attachment 93890 [details]
[PATCH] Suggested fix

View in context: https://bugs.webkit.org/attachment.cgi?id=93890&action=review

> Source/WebCore/inspector/InspectorCSSAgent.cpp:273
> +                collectStyleSheets(static_cast<CSSStyleSheet*>(styleSheet), styleInfos->get(), maxImportDepth);

Could you please test this scenario?

> Source/WebCore/inspector/InspectorCSSAgent.cpp:431
> +                collectStyleSheets(static_cast<CSSStyleSheet*>(importedStyleSheet), result, depth - 1);

What if A and B import C. Does C stylesheet materialize into two different CSSStyleSheet instances?

[Alexander Pavlov (apavlov)]

(In reply to comment #2)
> (From update of attachment 93890 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=93890&action=review
> 
> > Source/WebCore/inspector/InspectorCSSAgent.cpp:273
> > +                collectStyleSheets(static_cast<CSSStyleSheet*>(styleSheet), styleInfos->get(), maxImportDepth);
> 
> Could you please test this scenario?

Done.

> > Source/WebCore/inspector/InspectorCSSAgent.cpp:431
> > +                collectStyleSheets(static_cast<CSSStyleSheet*>(importedStyleSheet), result, depth - 1);
> 
> What if A and B import C. Does C stylesheet materialize into two different CSSStyleSheet instances?

Yes, it does.

[Alexander Pavlov (apavlov)]

Created attachment 93893 [details]
[PATCH] Comments addressed

[Alexander Pavlov (apavlov)]

Committed r86754: <http://trac.webkit.org/changeset/86754>