Bug 60956 - [Qt] Implement LayoutTestController::setValueForUser
Summary: [Qt] Implement LayoutTestController::setValueForUser
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kristóf Kosztyó
Depends on:
Reported: 2011-05-17 06:42 PDT by Kristóf Kosztyó
Modified: 2011-05-18 02:11 PDT (History)
4 users (show)

See Also:

proposed fix (5.61 KB, patch)
2011-05-17 06:48 PDT, Kristóf Kosztyó
no flags Details | Formatted Diff | Diff
proposed fix (5.67 KB, patch)
2011-05-17 08:15 PDT, Kristóf Kosztyó
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kristóf Kosztyó 2011-05-17 06:42:18 PDT
fast/forms/onchange-setvalueforuser.html is failed on Qt because the implement of layoutTestController.setValueForUser() is missing.
Comment 1 Kristóf Kosztyó 2011-05-17 06:48:59 PDT
Created attachment 93761 [details]
proposed fix
Comment 2 Andras Becsi 2011-05-17 07:09:47 PDT
Comment on attachment 93761 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=93761&action=review

Besides one missing changelog line, the patch looks ok to me.
Ossy will r+ it.
Keep up the good work.

> LayoutTests/ChangeLog:8
> +        * platform/qt/Skipped:

You should mention here which test you unskip, but this can be done before landing.
Comment 3 Kristóf Kosztyó 2011-05-17 08:15:59 PDT
Created attachment 93768 [details]
proposed fix
Comment 4 Luiz Agostini 2011-05-17 12:27:21 PDT
Comment on attachment 93768 [details]
proposed fix

I am not an official reviewer but it LGTM.
Comment 5 Csaba Osztrogonác 2011-05-18 00:09:57 PDT
Great, r=me.
Comment 6 WebKit Commit Bot 2011-05-18 02:11:00 PDT
Comment on attachment 93768 [details]
proposed fix

Clearing flags on attachment: 93768

Committed r86742: <http://trac.webkit.org/changeset/86742>
Comment 7 WebKit Commit Bot 2011-05-18 02:11:05 PDT
All reviewed patches have been landed.  Closing bug.