RESOLVED FIXED 60937
SunSpider: string-validate-input.js uses an undeclared variable named 'name', which is a DOM API
https://bugs.webkit.org/show_bug.cgi?id=60937
Summary SunSpider: string-validate-input.js uses an undeclared variable named 'name',...
Geoffrey Garen
Reported 2011-05-16 17:44:36 PDT
Here's the code: name = makeName(6); (k%2)?email=name+"@mac.com":email=name+"(at)mac.com"; Since 'name' is undeclared, and window.name defaults to the DOM frame name API, this test spends a bunch of time getting and setting the name of the frame in the DOM. Of course we want the DOM to be fast, but testing the DOM seems contrary to the goals of SunSpider.
Attachments
Patch (1.41 KB, patch)
2011-07-02 13:53 PDT, Maciej Stachowiak
mitz: review+
Alexey Proskuryakov
Comment 1 2011-05-16 23:18:45 PDT
This is fixed in a r-'ed patch attached to bug 17634, although with a slightly different rationale.
Geoffrey Garen
Comment 2 2011-05-17 16:57:24 PDT
It looks like Maciej planned to fix this, but never got around to it. I think the important issue is to pick a name that doesn't conflict with a DOM API. Whether the variable is declared as a var or not is no big deal.
Maciej Stachowiak
Comment 3 2011-07-02 13:53:49 PDT
Maciej Stachowiak
Comment 4 2011-07-02 13:57:46 PDT
Note You need to log in before you can comment on or make changes to this bug.