Bug 60925 - Document why RenderBlockLineLayout has its own deleteLineBoxTree implementation
Summary: Document why RenderBlockLineLayout has its own deleteLineBoxTree implementation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 60113 60729
  Show dependency tree / graph
 
Reported: 2011-05-16 14:51 PDT by Eric Seidel (no email)
Modified: 2011-05-16 16:11 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.01 KB, patch)
2011-05-16 14:53 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2011-05-16 14:51:22 PDT 
Document why RenderBlockLineLayout has its own deleteLineBoxTree implementation
Comment 1 Eric Seidel (no email) 2011-05-16 14:53:25 PDT 
Created attachment 93697 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-05-16 14:57:13 PDT 
I tried to change this to deleteLineBoxTree in multiple different patches, and then was confused when things started crashing.  I suspect that this code as-is is just papering over other bugs, but I'm leaving it as-is for now and documenting why it is that way.
Comment 3 Adam Barth 2011-05-16 15:09:22 PDT 
Comment on attachment 93697 [details]
Patch

Ok...
Comment 4 WebKit Commit Bot 2011-05-16 16:11:01 PDT 
Comment on attachment 93697 [details]
Patch

Clearing flags on attachment: 93697

Committed r86628: <http://trac.webkit.org/changeset/86628>
Comment 5 WebKit Commit Bot 2011-05-16 16:11:08 PDT 
All reviewed patches have been landed.  Closing bug.