Bug 60923 - editing/pasteboard/5075944-2.html and 5075944-3.html should be renamed and converted to dump-as-markup tests
Summary: editing/pasteboard/5075944-2.html and 5075944-3.html should be renamed and co...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 60914
  Show dependency tree / graph
 
Reported: 2011-05-16 14:20 PDT by Ryosuke Niwa
Modified: 2011-05-26 15:40 PDT (History)
6 users (show)

See Also:

Attachments
converted tests (18.55 KB, patch)
2011-05-16 15:09 PDT, Ryosuke Niwa 		enrica: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-05-16 14:20:37 PDT 
5075944-2.html needs to verify the color of the underline but render tree dump can't capture this information.  We should convert this test to a dump-as-markup test so that we can see text diff when it regresses.  Also, we should give it a more descriptive name.
Comment 1 Ryosuke Niwa 2011-05-16 14:22:06 PDT 
Ditto: 5075944-3.html
Comment 2 Ryosuke Niwa 2011-05-16 15:09:05 PDT 
Created attachment 93702 [details]
converted tests
Comment 3 Enrica Casucci 2011-05-16 15:31:31 PDT 
Comment on attachment 93702 [details]
converted tests

Do you need results for the windows build?
Comment 4 Ryosuke Niwa 2011-05-16 15:35:20 PDT 
(In reply to comment #3)
> (From update of attachment 93702 [details])
> Do you need results for the windows build?

I don't think so.  By the way, I realized that I forgot to remove old expected results for 5075944-3.html.  Will remove before landing the patch.
Comment 5 Ryosuke Niwa 2011-05-16 15:42:24 PDT 
Thanks for the review, Enrica!  Landing it now.
Comment 6 Ryosuke Niwa 2011-05-16 15:46:34 PDT 
Committed r86619: <http://trac.webkit.org/changeset/86619>
Comment 7 Ademar Reis 2011-05-23 14:08:00 PDT 
Revision r86619 cherry-picked into qtwebkit-2.2 with commit d75ec39 <http://gitorious.org/webkit/qtwebkit/commit/d75ec39>
Comment 8 Ademar Reis 2011-05-26 15:40:23 PDT 
Revision r86619 cherry-picked into qtwebkit-2.2 with commit d18ba15 <http://gitorious.org/webkit/qtwebkit/commit/d18ba15>