JSWeakObjectMap finalisation may occur while gc is in inconsistent state
Created attachment 93670 [details] Patch
Comment on attachment 93670 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=93670&action=review Please file a bug to track the better long-term change we discussed, which makes weak maps reference-counted in the API, based on a linked-on-or-after check > Source/JavaScriptCore/runtime/JSGlobalObject.h:116 > + static JS_EXPORTDATA WeakMapFinalizer s_weakMapFinalizer; These names really should be plural -- "WeakMapsFinalizer, s_weakMapsFinalizer", etc.
Committed r86594: <http://trac.webkit.org/changeset/86594>
Comment on attachment 93670 [details] Patch Attachment 93670 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/8699931