WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
60908
JSWeakObjectMap finalisation may occur while gc is in inconsistent state
https://bugs.webkit.org/show_bug.cgi?id=60908
Summary
JSWeakObjectMap finalisation may occur while gc is in inconsistent state
Oliver Hunt
Reported
2011-05-16 11:05:41 PDT
JSWeakObjectMap finalisation may occur while gc is in inconsistent state
Attachments
Patch
(3.84 KB, patch)
2011-05-16 11:09 PDT
,
Oliver Hunt
ggaren
: review+
webkit.review.bot
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Oliver Hunt
Comment 1
2011-05-16 11:09:15 PDT
Created
attachment 93670
[details]
Patch
Geoffrey Garen
Comment 2
2011-05-16 11:22:16 PDT
Comment on
attachment 93670
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=93670&action=review
Please file a bug to track the better long-term change we discussed, which makes weak maps reference-counted in the API, based on a linked-on-or-after check
> Source/JavaScriptCore/runtime/JSGlobalObject.h:116 > + static JS_EXPORTDATA WeakMapFinalizer s_weakMapFinalizer;
These names really should be plural -- "WeakMapsFinalizer, s_weakMapsFinalizer", etc.
Oliver Hunt
Comment 3
2011-05-16 11:54:55 PDT
Committed
r86594
: <
http://trac.webkit.org/changeset/86594
>
WebKit Review Bot
Comment 4
2011-05-16 12:24:22 PDT
Comment on
attachment 93670
[details]
Patch
Attachment 93670
[details]
did not pass mac-ews (mac): Output:
http://queues.webkit.org/results/8699931
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug