Bug 60908 - JSWeakObjectMap finalisation may occur while gc is in inconsistent state
Summary: JSWeakObjectMap finalisation may occur while gc is in inconsistent state
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-16 11:05 PDT by Oliver Hunt
Modified: 2011-05-16 12:24 PDT (History)
0 users

See Also:


Attachments
Patch (3.84 KB, patch)
2011-05-16 11:09 PDT, Oliver Hunt
ggaren: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2011-05-16 11:05:41 PDT
JSWeakObjectMap finalisation may occur while gc is in inconsistent state
Comment 1 Oliver Hunt 2011-05-16 11:09:15 PDT
Created attachment 93670 [details]
Patch
Comment 2 Geoffrey Garen 2011-05-16 11:22:16 PDT
Comment on attachment 93670 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=93670&action=review

Please file a bug to track the better long-term change we discussed, which makes weak maps reference-counted in the API, based on a linked-on-or-after check

> Source/JavaScriptCore/runtime/JSGlobalObject.h:116
> +        static JS_EXPORTDATA WeakMapFinalizer s_weakMapFinalizer;

These names really should be plural -- "WeakMapsFinalizer, s_weakMapsFinalizer", etc.
Comment 3 Oliver Hunt 2011-05-16 11:54:55 PDT
Committed r86594: <http://trac.webkit.org/changeset/86594>
Comment 4 WebKit Review Bot 2011-05-16 12:24:22 PDT
Comment on attachment 93670 [details]
Patch

Attachment 93670 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/8699931