Bug 60900 – Web Inspector: refactoring: ScriptDebugListener::didParseSource has too many parameters.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Podivilov]

Web Inspector: refactoring: ScriptDebugListener::didParseSource has too many parameters.

[Pavel Podivilov]

Created attachment 93657 [details]
Patch.

[WebKit Review Bot]

Attachment 93657 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/inspector/ScriptDebugListener.h:68:  The parameter name "script" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorDebuggerAgent.h:123:  The parameter name "script" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Pavel Podivilov]

Created attachment 93659 [details]
Fix style.

[WebKit Review Bot]

Comment on attachment 93657 [details]
Patch.

Attachment 93657 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/8698919

[WebKit Review Bot]

Comment on attachment 93659 [details]
Fix style.

Attachment 93659 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/8699909

[Pavel Podivilov]

Created attachment 93676 [details]
Fix warning.

[Yury Semikhatsky]

Comment on attachment 93676 [details]
Fix warning.

View in context: https://bugs.webkit.org/attachment.cgi?id=93676&action=review

> Source/WebCore/inspector/ScriptDebugListener.h:50
> +            , endColumn(0)

linesCount(0) is missing

> Source/WebCore/inspector/ScriptDebugListener.h:62
> +        int linesCount;

This field is never used, please remove it.

[Pavel Podivilov]

Created attachment 93786 [details]
Patch.

[Pavel Podivilov]

(In reply to comment #7)
> (From update of attachment 93676 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=93676&action=review
> 
> > Source/WebCore/inspector/ScriptDebugListener.h:50
> > +            , endColumn(0)
> 
> linesCount(0) is missing
> 
> > Source/WebCore/inspector/ScriptDebugListener.h:62
> > +        int linesCount;
> 
> This field is never used, please remove it.

Done.

[Pavel Podivilov]

Committed r86756: <http://trac.webkit.org/changeset/86756>